Page MenuHomePhabricator

GetMemoryRegions for the ProcessMinidump
ClosedPublic

Authored by tatyana-krasnukha on Dec 18 2018, 10:52 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

clayborg requested changes to this revision.Dec 18 2018, 1:13 PM

Change looks good.

We need to add a test for this. You can use the minidump file from "lldb/unittests/Process/minidump/Inputs/regions-linux-map.dmp" and copy it over into "lldb/packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new" and then add a test to "packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py" to ensure this doesn't regress.

This revision now requires changes to proceed.Dec 18 2018, 1:13 PM

Add a test

There was one added. See code

Add a test

There was one added. See code

Never mind, I thought this was my patch! Ignore me...

clayborg requested changes to this revision.Dec 19 2018, 10:41 AM

Just remove the "regions-linux-map.dmp" as I already checked one in with rLLDB349658 and this is good to go

packages/Python/lldbsuite/test/functionalities/postmortem/minidump-new/TestMiniDumpNew.py
427 ↗(On Diff #178916)

BTW: I added this file already with my last patch, so you can remove the "regions-linux-map.dmp" from the SVN commit. Just update your sources and make sure it matches and works.

This revision now requires changes to proceed.Dec 19 2018, 10:41 AM

Removed dump file from the patch

clayborg accepted this revision.Dec 19 2018, 12:18 PM

Looks good!

This revision is now accepted and ready to land.Dec 19 2018, 12:18 PM
This revision was automatically updated to reflect the committed changes.