This is an archive of the discontinued LLVM Phabricator instance.

hwasan: Allow range of frame descriptors to be empty.
ClosedPublic

Authored by pcc on Dec 17 2018, 4:45 PM.

Reviewers

Commits

Summary

As of r349413 it's now possible for a binary to contain an empty
hwasan frame section. Handle that case simply by doing nothing.

LGTM
consider keeping a CHECK_GE(end, beg)

This revision is now accepted and ready to land.Dec 17 2018, 4:47 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

lib/

hwasan/

4 lines

Show First 20 Lines • Show All 223 Lines • ▼ Show 20 Lines	struct FrameDescriptionArray {
FrameDescription beg, end;		FrameDescription beg, end;
};		};

static InternalMmapVectorNoCtor<FrameDescriptionArray> AllFrames;		static InternalMmapVectorNoCtor<FrameDescriptionArray> AllFrames;

void InitFrameDescriptors(uptr b, uptr e) {		void InitFrameDescriptors(uptr b, uptr e) {
FrameDescription beg = reinterpret_cast<FrameDescription >(b);		FrameDescription beg = reinterpret_cast<FrameDescription >(b);
FrameDescription end = reinterpret_cast<FrameDescription >(e);		FrameDescription end = reinterpret_cast<FrameDescription >(e);
// Must have at least one entry, which we can use for a linked list.		if (beg == end)
CHECK_GE(end - beg, 1U);		return;
AllFrames.push_back({beg, end});		AllFrames.push_back({beg, end});
if (Verbosity())		if (Verbosity())
for (FrameDescription *frame_descr = beg; frame_descr < end; frame_descr++)		for (FrameDescription *frame_descr = beg; frame_descr < end; frame_descr++)
Printf("Frame: %p %s\n", frame_descr->PC, frame_descr->Descr);		Printf("Frame: %p %s\n", frame_descr->PC, frame_descr->Descr);
}		}

const char *GetStackFrameDescr(uptr pc) {		const char *GetStackFrameDescr(uptr pc) {
for (uptr i = 0, n = AllFrames.size(); i < n; i++)		for (uptr i = 0, n = AllFrames.size(); i < n; i++)
▲ Show 20 Lines • Show All 313 Lines • Show Last 20 Lines