Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/Target/Mips/AsmParser/MipsAsmParser.cpp | ||
---|---|---|
792 ↗ | (On Diff #14938) | This method is never called. I think the problem is that you use parseRegisterList for parsing RegList16 operands. At the end of parseRegisterList, operand of k_RegList is created, which means that isRegList() will be called instead of isRegList16(). |
lib/Target/Mips/MicroMipsInstrInfo.td | ||
215 ↗ | (On Diff #14938) | You probably need RegListAsmOperand here. |
Comment Actions
For the following illegal instructions the error is not reported:
lwm16 $16, 8($sp)
lwm16 $16, $17, 8($sp)
lwm16 $16-$20, 8($sp)
Please include these instructions in the tests, to make sure the error is reported.
lib/Target/Mips/Disassembler/MipsDisassembler.cpp | ||
---|---|---|
348 ↗ | (On Diff #16289) | You can put "unsigned Insn" on the previous line - it fits in 80 columns. |
1422 ↗ | (On Diff #16289) | Same here. |