Page MenuHomePhabricator

[Utils] Attempt to fix clang.natvis following "[AST] Various optimizations in DeclarationName(Table)"
AbandonedPublic

Authored by riccibruno on Dec 15 2018, 5:46 AM.

Details

Reviewers
aaron.ballman
Summary

[AST] Various optimizations in DeclarationName(Table) changed how DeclarationNames
are represented. Therefore clang.natvis needs to be updated to reflect these changes.

This is completely untested since I actually don't have access to a windows machine.
However it should be close enough to a working fix.

Diff Detail

Repository
rC Clang

Event Timeline

riccibruno created this revision.Dec 15 2018, 5:46 AM

There was a bit more work to be done here, but this got me started. I commit extra fixes on top of your work in r349547 since I was able to test the behavior locally. Thank you for the help!

riccibruno abandoned this revision.Dec 18 2018, 2:14 PM

There was a bit more work to be done here, but this got me started. I commit extra fixes on top of your work in r349547 since I was able to test the behavior locally. Thank you for the help!

Nice ! I see that you fixed the FunctionProtoType case too.