This is an archive of the discontinued LLVM Phabricator instance.

Differential D55419

[yaml2obj] format some codes NFC.
ClosedPublic

Authored by Higuoxing on Dec 7 2018, 2:30 AM.

Details

Reviewers
None
Commits
rGbac7864a53f4: [yaml2obj] format some codes NFC.
rG63e123464b4f: [yaml2obj] format some codes NFC.
rL348580: [yaml2obj] format some codes NFC.
rL348578: [yaml2obj] format some codes NFC.
Summary

This line is longer than 80 characters.

Diff Detail

Event Timeline

Higuoxing created this revision.Dec 7 2018, 2:30 AM
Herald added a subscriber: jakehehrlich. · View Herald TranscriptDec 7 2018, 2:30 AM
Higuoxing updated this revision to Diff 177153.Dec 7 2018, 2:32 AM

Rebase

Herald added a subscriber: llvm-commits. · View Herald TranscriptDec 7 2018, 2:32 AM
Harbormaster completed remote builds in B25815: Diff 177153.Dec 7 2018, 2:32 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 7 2018, 2:34 AM
Closed by commit rL348578: [yaml2obj] format some codes NFC. (authored by Higuoxing). · Explain Why
This revision was automatically updated to reflect the committed changes.
Higuoxing added a comment.EditedDec 7 2018, 2:38 AM

reverted

Higuoxing reopened this revision.Dec 7 2018, 3:05 AM
Higuoxing updated this revision to Diff 177161.Dec 7 2018, 3:06 AM

rebase

Harbormaster completed remote builds in B25816: Diff 177161.Dec 7 2018, 3:06 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 7 2018, 3:07 AM
Closed by commit rL348580: [yaml2obj] format some codes NFC. (authored by Higuoxing). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
tools/
yaml2obj/
3 lines

Diff 177153

tools/yaml2obj/yaml2elf.cpp

Show First 20 Lines • Show All 679 Lines • ▼ Show 20 Lines
} }
template <class ELFT> bool ELFState<ELFT>::hasDynamicSymbols() const { template <class ELFT> bool ELFState<ELFT>::hasDynamicSymbols() const {
return Doc.DynamicSymbols.Global.size() > 0 || return Doc.DynamicSymbols.Global.size() > 0 ||
Doc.DynamicSymbols.Weak.size() > 0 || Doc.DynamicSymbols.Weak.size() > 0 ||
Doc.DynamicSymbols.Local.size() > 0; Doc.DynamicSymbols.Local.size() > 0;
} }
template <class ELFT> SmallVector<const char *, 5> ELFState<ELFT>::implicitSectionNames() const { template <class ELFT>
SmallVector<const char *, 5> ELFState<ELFT>::implicitSectionNames() const {
if (!hasDynamicSymbols()) if (!hasDynamicSymbols())
return {".symtab", ".strtab", ".shstrtab"}; return {".symtab", ".strtab", ".shstrtab"};
return {".symtab", ".strtab", ".shstrtab", ".dynsym", ".dynstr"}; return {".symtab", ".strtab", ".shstrtab", ".dynsym", ".dynstr"};
} }
static bool is64Bit(const ELFYAML::Object &Doc) { static bool is64Bit(const ELFYAML::Object &Doc) {
return Doc.Header.Class == ELFYAML::ELF_ELFCLASS(ELF::ELFCLASS64); return Doc.Header.Class == ELFYAML::ELF_ELFCLASS(ELF::ELFCLASS64);
} }
Show All 18 Lines