[analyzer] Fix an infinite recursion bug while checking parent methods in RetainCountChecker

[NoQ]

^^

cfe/trunk/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp

if (!PointeeTy.isNull()) {
         Template->addArg(AF, parm_idx, UnretainedOutParameter);
         return true;
       }
     }
   } else {
     if (const auto *MD = dyn_cast<CXXMethodDecl>(FD)) {
       for (const auto *OD : MD->overridden_methods()) {
         const ParmVarDecl *OP = OD->parameters()[parm_idx];
-        if (applyFunctionParamAnnotationEffect(OP, parm_idx, MD, AF, Template))
+        if (applyFunctionParamAnnotationEffect(OP, parm_idx, OD, AF, Template))
           return true;
       }
     }
   }
 
   return false;
 }
 

cfe/trunk/test/Analysis/osobject-retain-release.cpp

 
 struct OSArray : public OSObject {
   unsigned int getCount();
 
   OSIterator * getIterator();
 
   OSObject *identity() override;
 
+  virtual OSObject *generateObject(OSObject *input);
+
   virtual void consumeReference(OS_CONSUME OSArray *other);
 
   static OSArray *generateArrayHasCode() {
     return new OSArray;
   }
 
   static OSArray *withCapacity(unsigned int capacity);
   static void consumeArray(OS_CONSUME OSArray * array);
 
   static OSArray* consumeArrayHasCode(OS_CONSUME OSArray * array) {
     return nullptr;
   }
 
   static OS_RETURNS_NOT_RETAINED OSArray *MaskedGetter();
   static OS_RETURNS_RETAINED OSArray *getOoopsActuallyCreate();
 
   static const OSMetaClass * const metaClass;
 };
 
 struct MyArray : public OSArray {
   void consumeReference(OSArray *other) override;
 
   OSObject *identity() override;
+
+  OSObject *generateObject(OSObject *input) override;
 };
 
 struct OtherStruct {
   static void doNothingToArray(OSArray *array);
   OtherStruct(OSArray *arr);
 };
 
 struct OSMetaClassBase {
   static OSObject *safeMetaCast(const OSObject *inst, const OSMetaClass *meta);
 };
 
+void test_no_infinite_check_recursion(MyArray *arr) {
+  OSObject *input = new OSObject;
+  OSObject *o = arr->generateObject(input);
+  o->release();
+  input->release();
+}
+
+
 void check_param_attribute_propagation(MyArray *parent) {
   OSArray *arr = new OSArray;
   parent->consumeReference(arr);
 }
 
 unsigned int check_attribute_propagation(OSArray *arr) {
   OSObject *other = arr->identity();
   OSArray *casted = OSDynamicCast(OSArray, other);