Page MenuHomePhabricator

fix PointerIntPair visualizer
ClosedPublic

Authored by Trass3r on Dec 3 2018, 10:57 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

Trass3r created this revision.Dec 3 2018, 10:57 PM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 14 2018, 10:23 AM
Closed by commit rL349172: Fix Visual Studio PointerIntPair visualizer (authored by zturner, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

Thank you for working on this, but it seems like the fix didn't go quite far enough. There are other uses of IntShift in the natvis file that are causing problems, like the ones from the PointerUnion visualizers a few lines below what was updated. I don't suppose you'd be interested in getting the rest of the uses of IntShift cleaned up as well?

Simply didn't look for other uses of IntShift :)
I'm currently not working on llvm but I still have a bunch of half-decent visualizers for llvm::Value types and the like.