This is an archive of the discontinued LLVM Phabricator instance.

[COFF] Remove an outdated/incorrect comment. NFC.
ClosedPublic

Authored by mstorsjo on Dec 3 2018, 3:41 AM.

Details

Reviewers
rnk
ruiu
pcc
Summary

Making the section writable doesn't affect how windows does base relocs in case a DLL can't be loaded at the intended base address.

This comment dates back to SVN r79346.

Diff Detail

Event Timeline

mstorsjo created this revision.Dec 3 2018, 3:41 AM
rnk accepted this revision.Dec 3 2018, 8:27 AM

Lgtm yep, that fixme is not relevant.

This revision is now accepted and ready to land.Dec 3 2018, 8:27 AM
mstorsjo closed this revision.Dec 3 2018, 3:08 PM

Committed in SVN r348178.