Page MenuHomePhabricator

[KMSAN] Enable -msan-handle-asm-conservative by default
AcceptedPublic

Authored by glider on Nov 30 2018, 4:27 AM.

Details

Reviewers
dvyukov
eugenis
Summary

This change enables conservative assembly instrumentation in KMSAN builds by default.
It's still possible to disable it with -msan-handle-asm-conservative=0 if something breaks.
It's now impossible to enable conservative instrumentation for userspace builds, but it's not used anyway.

Diff Detail

Event Timeline

glider created this revision.Nov 30 2018, 4:27 AM
dvyukov accepted this revision.Nov 30 2018, 4:36 AM
This revision is now accepted and ready to land.Nov 30 2018, 4:36 AM
glider updated this revision to Diff 176121.Nov 30 2018, 7:38 AM

Updated the tests. Those were written with userspace instrumentation in mind, which isn't the case anymore.

dvyukov accepted this revision.Dec 3 2018, 12:56 AM

As per offline discussion: none of these tests test something that was used in user-space. So it does not make sense forking them for userspace/kernel.