This is an archive of the discontinued LLVM Phabricator instance.

[CMake] build correctly if build path contains whitespace (https://bugs.llvm.org/show_bug.cgi?id=39843)
ClosedPublic

Authored by johngarvin on Nov 29 2018, 2:59 PM.

Details

Summary

The add_llvm_symbol_exports function in AddLLVM.cmake creates command line link flags with paths containing CMAKE_CURRENT_BINARY_DIR, but that will break if CMAKE_CURRENT_BINARY_DIR contains whitespace. This patch adds quotes to those paths.

Diff Detail

Repository
rL LLVM

Event Timeline

johngarvin created this revision.Nov 29 2018, 2:59 PM
smeenai accepted this revision.Nov 29 2018, 3:01 PM
smeenai added a subscriber: smeenai.

Straightforward fix, so LGTM.

Do you have commit access?

This revision is now accepted and ready to land.Nov 29 2018, 3:01 PM

No, I don't have commit access.

This revision was automatically updated to reflect the committed changes.