[analyzer] For OSObject, trust that functions starting with Get

[george.karpenkov]

Summary

(uppercase) are also getters.

[NoQ]

clang/test/Analysis/osobject-retain-release.cpp

61–68 ↗

(On Diff #175783)

// no-warning

cfe/trunk/lib/StaticAnalyzer/Core/RetainSummaryManager.cpp

if (RetTy->isPointerType()) {
     if (TrackOSObjects && PD && isOSObjectSubclass(PD)) {
       if (const IdentifierInfo *II = FD->getIdentifier()) {
 
         if (isOSObjectDynamicCast(II->getName()))
           return getDefaultSummary();
 
         // All objects returned with functions *not* starting with
         // get, or iterators, are returned at +1.
-        if (!II->getName().startswith("get") || isOSIteratorSubclass(PD)) {
+        if ((!II->getName().startswith("get") &&
+             !II->getName().startswith("Get")) ||
+            isOSIteratorSubclass(PD)) {
           return getOSSummaryCreateRule(FD);
         } else {
           return getOSSummaryGetRule(FD);
         }
       }
     }
 
     // For CoreFoundation ('CF') types.

cfe/trunk/test/Analysis/osobject-retain-release.cpp

struct OSObject {
   virtual void retain();
   virtual void release() {};
   virtual ~OSObject(){}
 
   unsigned int foo() { return 42; }
 
   static OSObject *generateObject(int);
 
+  static OSObject *getObject();
+  static OSObject *GetObject();
+
   static const OSMetaClass * const metaClass;
 };
 
 struct OSIterator : public OSObject {
 
   static const OSMetaClass * const metaClass;
 };
 
struct OtherStruct {
   static void doNothingToArray(OSArray *array);
   OtherStruct(OSArray *arr);
 };
 
 struct OSMetaClassBase {
   static OSObject *safeMetaCast(const OSObject *inst, const OSMetaClass *meta);
 };
 
+void check_get_object() {
+  OSObject::getObject();
+}
+
+void check_Get_object() {
+  OSObject::GetObject();
+}
+
 void check_custom_iterator_rule(OSArray *arr) {
   OSIterator *it = arr->getIterator();
   it->release();
 }
 
 void check_iterator_leak(OSArray *arr) {
   arr->getIterator(); // expected-note{{Call to method 'OSArray::getIterator' returns an OSObject of type struct OSIterator * with a +1 retain count}}
 } // expected-note{{Object leaked: allocated object of type struct OSIterator * is not referenced later}}