This is an archive of the discontinued LLVM Phabricator instance.

Mark __builtin_shufflevector as using custom type checking
ClosedPublic

Authored by arsenm on Nov 28 2018, 1:22 PM.

Download Raw Diff

Details

Reviewers

Anastasia
efriedma

Summary

The custom handling seems to all be implemented already.
This avoids regressions in a future patch when float vectors
are ordinarily promoted to double vectors in variadic calls.

Diff Detail

Event Timeline

arsenm created this revision.Nov 28 2018, 1:22 PM

Herald added a subscriber: wdng. · View Herald TranscriptNov 28 2018, 1:22 PM

arsenm added a child revision: D55023: OpenCL: Improve vector printf warnings.Nov 28 2018, 1:27 PM

LGTM

This revision is now accepted and ready to land.Nov 28 2018, 2:22 PM

LGTM!

r347873

Revision Contents

Path

Size

include/

clang/

Basic/

Builtins.def

2 lines

Diff 175757

include/clang/Basic/Builtins.def

	Show First 20 Lines • Show All 532 Lines • ▼ Show 20 Lines

	BUILTIN(__builtin_unpredictable, "LiLi" , "nc")			BUILTIN(__builtin_unpredictable, "LiLi" , "nc")
	BUILTIN(__builtin_expect, "LiLiLi" , "nc")			BUILTIN(__builtin_expect, "LiLiLi" , "nc")
	BUILTIN(__builtin_prefetch, "vvC*.", "nc")			BUILTIN(__builtin_prefetch, "vvC*.", "nc")
	BUILTIN(__builtin_readcyclecounter, "ULLi", "n")			BUILTIN(__builtin_readcyclecounter, "ULLi", "n")
	BUILTIN(__builtin_trap, "v", "nr")			BUILTIN(__builtin_trap, "v", "nr")
	BUILTIN(__builtin_debugtrap, "v", "n")			BUILTIN(__builtin_debugtrap, "v", "n")
	BUILTIN(__builtin_unreachable, "v", "nr")			BUILTIN(__builtin_unreachable, "v", "nr")
	BUILTIN(__builtin_shufflevector, "v." , "nc")			BUILTIN(__builtin_shufflevector, "v." , "nct")
	BUILTIN(__builtin_convertvector, "v." , "nct")			BUILTIN(__builtin_convertvector, "v." , "nct")
	BUILTIN(__builtin_alloca, "v*z" , "Fn")			BUILTIN(__builtin_alloca, "v*z" , "Fn")
	BUILTIN(__builtin_alloca_with_align, "v*zIz", "Fn")			BUILTIN(__builtin_alloca_with_align, "v*zIz", "Fn")
	BUILTIN(__builtin_call_with_static_chain, "v.", "nt")			BUILTIN(__builtin_call_with_static_chain, "v.", "nt")

	// "Overloaded" Atomic operator builtins. These are overloaded to support data			// "Overloaded" Atomic operator builtins. These are overloaded to support data
	// types of i8, i16, i32, i64, and i128. The front-end sees calls to the			// types of i8, i16, i32, i64, and i128. The front-end sees calls to the
	// non-suffixed version of these (which has a bogus type) and transforms them to			// non-suffixed version of these (which has a bogus type) and transforms them to
	▲ Show 20 Lines • Show All 971 Lines • Show Last 20 Lines