This is an archive of the discontinued LLVM Phabricator instance.

Fix objc_sync_exit TSAN interceptor
ClosedPublic

Authored by yln on Nov 26 2018, 11:08 AM.

Reviewers

kubamracek

Summary

Fix copy & paste mistake

LGTM.

This revision is now accepted and ready to land.Nov 26 2018, 11:12 AM

Closing manually, since somehow I managed to mess up the commit message (it's empty).
Fixed by https://reviews.llvm.org/rCRT347788.

Path

Size

compiler-rt/

lib/

tsan/

rtl/

2 lines

	Show First 20 Lines • Show All 320 Lines • ▼ Show 20 Lines
	TSAN_INTERCEPTOR(int, objc_sync_enter, void *obj) {			TSAN_INTERCEPTOR(int, objc_sync_enter, void *obj) {
	SCOPED_TSAN_INTERCEPTOR(objc_sync_enter, obj);			SCOPED_TSAN_INTERCEPTOR(objc_sync_enter, obj);
	int result = REAL(objc_sync_enter)(obj);			int result = REAL(objc_sync_enter)(obj);
	if (obj) Acquire(thr, pc, SyncAddressForObjCObject(obj));			if (obj) Acquire(thr, pc, SyncAddressForObjCObject(obj));
	return result;			return result;
	}			}

	TSAN_INTERCEPTOR(int, objc_sync_exit, void *obj) {			TSAN_INTERCEPTOR(int, objc_sync_exit, void *obj) {
	SCOPED_TSAN_INTERCEPTOR(objc_sync_enter, obj);			SCOPED_TSAN_INTERCEPTOR(objc_sync_exit, obj);
	if (obj) Release(thr, pc, SyncAddressForObjCObject(obj));			if (obj) Release(thr, pc, SyncAddressForObjCObject(obj));
	return REAL(objc_sync_exit)(obj);			return REAL(objc_sync_exit)(obj);
	}			}

	// On macOS, libc++ is always linked dynamically, so intercepting works the			// On macOS, libc++ is always linked dynamically, so intercepting works the
	// usual way.			// usual way.
	#define STDCXX_INTERCEPTOR TSAN_INTERCEPTOR			#define STDCXX_INTERCEPTOR TSAN_INTERCEPTOR

	▲ Show 20 Lines • Show All 88 Lines • Show Last 20 Lines