This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
llvm/utils/gn/
-
utils/
-
gn/
-
README.rst

Differential D54840

[GN][NFC] Update readme example to functional command
ClosedPublic

Authored by martell on Nov 22 2018, 4:32 PM.

Download Raw Diff

Details

Reviewers

thakis

Commits

rGdd702e217b19: [GN][NFC] Update readme example to functional command
rL348259: [GN][NFC] Update readme example to functional command

Summary

ninja -C out/gn check-lld is not a valid command with the current checkin.

Diff Detail

Repository: rL LLVM

Event Timeline

martell created this revision.Nov 22 2018, 4:32 PM

I really hope gn catches on and it also works with the tools layout ( i.e. llvm/tools/lld ) so I can make good use of ninja -C out/gn check-lld. :)

martell retitled this revision from [GN] : Update readme example to functional command to [GN][NFC] Update readme example to functional command.Nov 22 2018, 4:37 PM

lgtm; hopefully we remember to undo this once check-lld works :-)

This revision is now accepted and ready to land.Nov 26 2018, 5:27 AM

In D54840#1306533, @martell wrote:

I really hope gn catches on and it also works with the tools layout ( i.e. llvm/tools/lld ) so I can make good use of ninja -C out/gn check-lld. :)

As far as I understand, that layout will go away once the transition to the monorepo is done, so I haven't spent time on supporting it.

If you still want to land this, maybe use llvm-undname since that's a useful binary that now works.

Closed by commit rL348259: [GN][NFC] Update readme example to functional command (authored by martell). · Explain WhyDec 4 2018, 5:02 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

utils/

gn/

README.rst

3 lines

Diff 175073

llvm/utils/gn/README.rst

Context not available.
	build directory, it can have any name, and you can have as many as you want,	build directory, it can have any name, and you can have as many as you want,
	each with different build settings).	each with different build settings).

	#. Run e.g. `ninja -C out/gn check-lld` to build all prerequisites for and	#. Run e.g. `ninja -C out/gn Demangle` to build libDemangle.
	run the LLD tests.

	By default, you get a release build with assertions enabled that targets	By default, you get a release build with assertions enabled that targets
	the host arch. You can set various build options by editing `out/gn/args.gn`,	the host arch. You can set various build options by editing `out/gn/args.gn`,
Context not available.