This is an archive of the discontinued LLVM Phabricator instance.

[GN][NFC] Update readme example to functional command
ClosedPublic

Authored by martell on Nov 22 2018, 4:32 PM.

Details

Summary

ninja -C out/gn check-lld is not a valid command with the current checkin.

Diff Detail

Repository
rL LLVM

Event Timeline

martell created this revision.Nov 22 2018, 4:32 PM
martell added a comment.EditedNov 22 2018, 4:36 PM

I really hope gn catches on and it also works with the tools layout ( i.e. llvm/tools/lld ) so I can make good use of ninja -C out/gn check-lld. :)

martell retitled this revision from [GN] : Update readme example to functional command to [GN][NFC] Update readme example to functional command.Nov 22 2018, 4:37 PM
thakis accepted this revision.Nov 26 2018, 5:27 AM

lgtm; hopefully we remember to undo this once check-lld works :-)

This revision is now accepted and ready to land.Nov 26 2018, 5:27 AM

I really hope gn catches on and it also works with the tools layout ( i.e. llvm/tools/lld ) so I can make good use of ninja -C out/gn check-lld. :)

As far as I understand, that layout will go away once the transition to the monorepo is done, so I haven't spent time on supporting it.

If you still want to land this, maybe use llvm-undname since that's a useful binary that now works.

This revision was automatically updated to reflect the committed changes.