This is an archive of the discontinued LLVM Phabricator instance.

test/CMakeLists.txt
76 ↗	(On Diff #174925)	Nitpicking a bit but I think it would be better to uppercase it for consistency.
80 ↗	(On Diff #174925)	…and remove the space after `if`.

Address comments.

hokein marked 2 inline comments as done.Nov 22 2018, 1:41 AM

LGTM (assuming you've tested it).

This revision is now accepted and ready to land.Nov 22 2018, 1:50 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

clang-tools-extra/

trunk/

test/

11 lines

	Show First 20 Lines • Show All 65 Lines • ▼ Show 20 Lines
	set(CLANGD_TEST_DEPS			set(CLANGD_TEST_DEPS
	clangd			clangd
	ClangdTests			ClangdTests
	# clangd-related tools which don't have tests, add them to the test to make			# clangd-related tools which don't have tests, add them to the test to make
	# sure we don't introduce new changes that break their compilations.			# sure we don't introduce new changes that break their compilations.
	clangd-indexer			clangd-indexer
	dexp			dexp
	)			)

				# Add lit test dependencies.
				set(LLVM_UTILS_DEPS
				FileCheck count not
				)
				foreach(dep ${LLVM_UTILS_DEPS})
				if(TARGET ${dep})
				list(APPEND CLANGD_TEST_DEPS ${dep})
				endif()
				endforeach()

	foreach(clangd_dep ${CLANGD_TEST_DEPS})			foreach(clangd_dep ${CLANGD_TEST_DEPS})
	list(APPEND CLANG_TOOLS_TEST_DEPS			list(APPEND CLANG_TOOLS_TEST_DEPS
	${clangd_dep})			${clangd_dep})
	endforeach()			endforeach()

	add_lit_testsuite(check-clang-tools "Running the Clang extra tools' regression tests"			add_lit_testsuite(check-clang-tools "Running the Clang extra tools' regression tests"
	${CMAKE_CURRENT_BINARY_DIR}			${CMAKE_CURRENT_BINARY_DIR}
	DEPENDS ${CLANG_TOOLS_TEST_DEPS}			DEPENDS ${CLANG_TOOLS_TEST_DEPS}
	Show All 16 Lines