This is an archive of the discontinued LLVM Phabricator instance.

Swap order of discovering of -ltinfo and -lterminfo
ClosedPublic

Authored by krytarowski on Nov 16 2018, 2:01 PM.

Details

Summary

NetBSD ships with native curses(3) and -ltinfo is a part of ncurses.
Set -lterminfo before -ltinfo, as it allows to prioritize native curses
libraries. Mixing curses and ncurses does not work well, especially
in software built on top of llvm.

Original patch by Ryo Onodera (NetBSD) in pkgsrc.

Diff Detail

Repository
rL LLVM

Event Timeline

krytarowski created this revision.Nov 16 2018, 2:01 PM
mgorny accepted this revision.Nov 18 2018, 1:41 AM

LGTM. There's no terminfo on Linux (or majority of other systems, I suppose), so this shouldn't break anything. I've tested it on Linux, tests pass and there's no perceivable difference ;-).

This revision is now accepted and ready to land.Nov 18 2018, 1:41 AM
dim accepted this revision.Nov 18 2018, 3:25 AM

On FreeBSD, there is no libterminfo either, so LGTM.

This revision was automatically updated to reflect the committed changes.