This is an archive of the discontinued LLVM Phabricator instance.

[AST] Pack MemberExpr
ClosedPublic

Authored by riccibruno on Nov 14 2018, 5:59 AM.

Details

Summary

Use the newly available space in the bit-fields of Stmt
to store some data from MemberExpr. This saves
one pointer per MemberExpr.

Diff Detail

Repository
rC Clang

Event Timeline

riccibruno created this revision.Nov 14 2018, 5:59 AM
dblaikie accepted this revision.Nov 14 2018, 12:57 PM

Looks good - thanks!

include/clang/AST/Expr.h
2799–2802

Moving these around could/should be a separate NFC commit - did these have to move at all in this change or something you spotted along the way & cleaned up independently?

This revision is now accepted and ready to land.Nov 14 2018, 12:57 PM
riccibruno added inline comments.Nov 14 2018, 1:58 PM
include/clang/AST/Expr.h
2802

Having this at the bottom is so painful for the reader,
and people seems to put them at the top of the class usually.
But yes I can do this as an NFC.

riccibruno marked 2 inline comments as done.Nov 15 2018, 5:49 AM
This revision was automatically updated to reflect the committed changes.