Page MenuHomePhabricator

Add new API for returning matching matchers
AcceptedPublic

Authored by steveire on Nov 11 2018, 2:33 PM.

Details

Reviewers
aaron.ballman
Summary

The MatchingMatcher struct currently contains only a string, but it will
be expanded in the future.

Diff Detail

Event Timeline

steveire created this revision.Nov 11 2018, 2:33 PM
aaron.ballman added inline comments.Nov 11 2018, 3:31 PM
lib/ASTMatchers/Dynamic/Registry.cpp
604–605

std::vector<ArgKind> AcceptedTypes{StaticType}; instead?

608–611

Elide the identifiers for arguments that are not named in the lambda.

unittests/ASTMatchers/Dynamic/RegistryTest.cpp
563

Move the const to the other side of the declaration.

564

std::find_if(C.begin(), C.end(), ...) -> llvm::find_if(C, ...)

aaron.ballman accepted this revision.Nov 12 2018, 2:48 PM

LGTM aside from a minor commenting nit.

include/clang/ASTMatchers/Dynamic/Registry.h
106

I think we typically go with \p instead of @p in our doc comments.

This revision is now accepted and ready to land.Nov 12 2018, 2:48 PM