This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Mark C.EBREAK instruction as having side effects
ClosedPublic

Authored by luismarques on Nov 8 2018, 3:59 AM.

Details

Summary

C.EBREAK was defined with hasSideEffects = 0, which is incorrect and inconsistent with the non-compressed instruction form. This patch corrects this oversight.

Diff Detail

Repository
rL LLVM

Event Timeline

luismarques created this revision.Nov 8 2018, 3:59 AM
luismarques edited the summary of this revision. (Show Details)Nov 8 2018, 4:02 AM
asb accepted this revision.Nov 15 2018, 6:51 AM

Looks good to me. This won't cause any codegen issues because C_EBREAK is never gets selected in ISel anyway (EBREAK will get converted after it becomes an MCInst). But it's better to have the right metadata.

This revision is now accepted and ready to land.Nov 15 2018, 6:51 AM
This revision was automatically updated to reflect the committed changes.