This is an archive of the discontinued LLVM Phabricator instance.

Differential D54152

[OpenCL] Fix diagnostic message about overload candidates
ClosedPublic

Authored by AlexeySachkov on Nov 6 2018, 6:43 AM.

Details

Reviewers
asavonic
Anastasia
Commits
rG97754f4c0b71: [OpenCL] Fix diagnostic message about overload candidates
rL346311: [OpenCL] Fix diagnostic message about overload candidates
rC346311: [OpenCL] Fix diagnostic message about overload candidates
Summary

I wonder if there are some extension which need to be disabled to get
overloadable candidate available.

Diff Detail

Event Timeline

AlexeySachkov created this revision.Nov 6 2018, 6:43 AM
Herald added a subscriber: yaxunl. · View Herald TranscriptNov 6 2018, 6:43 AM
Anastasia accepted this revision.Nov 6 2018, 8:47 AM

LGTM! Thanks!

This revision is now accepted and ready to land.Nov 6 2018, 8:47 AM
Closed by commit rC346311: [OpenCL] Fix diagnostic message about overload candidates (authored by asavonic). · Explain WhyNov 7 2018, 5:09 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
include/
clang/
Basic/
2 lines
test/
SemaOpenCL/
2 lines

Diff 172757

include/clang/Basic/DiagnosticSemaKinds.td

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 3,675 Lines • ▼ Show 20 Linesdef note_ovl_candidate_has_pass_object_size_params: Note<
"candidate address cannot be taken because parameter %0 has " "candidate address cannot be taken because parameter %0 has "
"pass_object_size attribute">; "pass_object_size attribute">;
def err_diagnose_if_succeeded : Error<"%0">; def err_diagnose_if_succeeded : Error<"%0">;
def warn_diagnose_if_succeeded : Warning<"%0">, InGroup<UserDefinedWarnings>, def warn_diagnose_if_succeeded : Warning<"%0">, InGroup<UserDefinedWarnings>,
ShowInSystemHeader; ShowInSystemHeader;
def note_ovl_candidate_disabled_by_function_cond_attr : Note< def note_ovl_candidate_disabled_by_function_cond_attr : Note<
"candidate disabled: %0">; "candidate disabled: %0">;
def note_ovl_candidate_disabled_by_extension : Note< def note_ovl_candidate_disabled_by_extension : Note<
"candidate unavailable as it requires OpenCL extension '%0' to be disabled">; "candidate unavailable as it requires OpenCL extension '%0' to be enabled">;
def err_addrof_function_disabled_by_enable_if_attr : Error< def err_addrof_function_disabled_by_enable_if_attr : Error<
"cannot take address of function %0 because it has one or more " "cannot take address of function %0 because it has one or more "
"non-tautological enable_if conditions">; "non-tautological enable_if conditions">;
def note_addrof_ovl_candidate_disabled_by_enable_if_attr : Note< def note_addrof_ovl_candidate_disabled_by_enable_if_attr : Note<
"candidate function made ineligible by enable_if">; "candidate function made ineligible by enable_if">;
def note_ovl_candidate_deduced_mismatch : Note< def note_ovl_candidate_deduced_mismatch : Note<
"candidate template ignored: deduced type " "candidate template ignored: deduced type "
"%diff{$ of %select{|element of }4%ordinal0 parameter does not match " "%diff{$ of %select{|element of }4%ordinal0 parameter does not match "
▲ Show 20 Lines • Show All 5,846 Lines • Show Last 20 Lines

test/SemaOpenCL/extension-begin.cl

Show All 34 Lines
#pragma OPENCL EXTENSION my_ext : disable #pragma OPENCL EXTENSION my_ext : disable
void test_f2(void) { void test_f2(void) {
struct A test_A2; // expected-error {{use of type 'struct A' requires my_ext extension to be enabled}} struct A test_A2; // expected-error {{use of type 'struct A' requires my_ext extension to be enabled}}
const struct A test_A_local; // expected-error {{use of type 'struct A' requires my_ext extension to be enabled}} const struct A test_A_local; // expected-error {{use of type 'struct A' requires my_ext extension to be enabled}}
TypedefOfA test_typedef_A; // expected-error {{use of type 'TypedefOfA' (aka 'struct A') requires my_ext extension to be enabled}} TypedefOfA test_typedef_A; // expected-error {{use of type 'TypedefOfA' (aka 'struct A') requires my_ext extension to be enabled}}
PointerOfA test_A_pointer; // expected-error {{use of type 'PointerOfA' (aka 'const struct A *') requires my_ext extension to be enabled}} PointerOfA test_A_pointer; // expected-error {{use of type 'PointerOfA' (aka 'const struct A *') requires my_ext extension to be enabled}}
f(); // expected-error {{use of declaration 'f' requires my_ext extension to be enabled}} f(); // expected-error {{use of declaration 'f' requires my_ext extension to be enabled}}
g(0); // expected-error {{no matching function for call to 'g'}} g(0); // expected-error {{no matching function for call to 'g'}}
// expected-note@extension-begin.h:18 {{candidate unavailable as it requires OpenCL extension 'my_ext' to be disabled}} // expected-note@extension-begin.h:18 {{candidate unavailable as it requires OpenCL extension 'my_ext' to be enabled}}
// expected-note@extension-begin.h:23 {{candidate function not viable: requires 0 arguments, but 1 was provided}} // expected-note@extension-begin.h:23 {{candidate function not viable: requires 0 arguments, but 1 was provided}}
} }