This is an archive of the discontinued LLVM Phabricator instance.

Differential D5413

[mips][microMIPS] Disassembler tests for LWXS, BGEZALS, BLTZALS, BEQZC, BNEZC, JALS and JALRS instructions
ClosedPublic

Authored by jkolek on Sep 19 2014, 7:07 AM.

Details

Reviewers
sstankovic
dsanders
vmedic
Summary

Disassembler tests for new microMIPS 32-bit instructions: LWXS, BGEZALS, BLTZALS, BEQZC, BNEZC, JALS and JALRS.

Diff Detail

Event Timeline

jkolek updated this revision to Diff 13867.Sep 19 2014, 7:07 AM
jkolek retitled this revision from to [mips][microMIPS] Disassembler tests for LWXS, BGEZALS, BLTZALS, BEQZC, BNEZC, JALS and JALRS instructions.
jkolek updated this object.
jkolek edited the test plan for this revision. (Show Details)
jkolek added reviewers: dsanders, vmedic.
jkolek added a subscriber: zoran.jovanovic.
jkolek added a reviewer: sstankovic.Nov 14 2014, 6:07 AM
sstankovic added inline comments.Nov 14 2014, 9:43 AM
test/MC/Disassembler/Mips/micromips.txt
317

Disassembler currently doesn't support jalrs with only one register (where $ra is implicit). I think it should be implemented. Also, add a testcase for it.

sstankovic added inline comments.Nov 14 2014, 9:49 AM
test/MC/Disassembler/Mips/micromips.txt
317

Sorry, I meant assembler. But this should probably be part of a separate patch. (You may optionally add a TODO comment for it). So, this patch LGTM.

sstankovic accepted this revision.Nov 14 2014, 9:50 AM
sstankovic edited edge metadata.
This revision is now accepted and ready to land.Nov 14 2014, 9:50 AM
jkolek edited edge metadata.Nov 18 2014, 5:40 AM
jkolek added a subscriber: Unknown Object (MLST).
jkolek closed this revision.Nov 19 2014, 3:54 AM

Revision Contents

PathSize
test/
MC/
Disassembler/
Mips/
21 lines
21 lines

Diff 13867

test/MC/Disassembler/Mips/micromips.txt

Show First 20 Lines • Show All 288 Lines • ▼ Show 20 Lines
# CHECK: tnei $9, 17767 # CHECK: tnei $9, 17767
0x41 0x89 0x45 0x67 0x41 0x89 0x45 0x67
# CHECK: ll $2, 8($4) # CHECK: ll $2, 8($4)
0x60 0x44 0x30 0x08 0x60 0x44 0x30 0x08
# CHECK: sc $2, 8($4) # CHECK: sc $2, 8($4)
0x60 0x44 0xb0 0x08 0x60 0x44 0xb0 0x08
# CHECK: lwxs $2, $3($4)
0x00 0x64 0x11 0x18
# CHECK: bgezals $6, 1332
0x42 0x66 0x02 0x9a
# CHECK: bltzals $6, 1332
0x42 0x26 0x02 0x9a
# CHECK: beqzc $9, 1332
0x40 0xe9 0x02 0x9a
# CHECK: bnezc $9, 1332
0x40 0xa9 0x02 0x9a
# CHECK: jals 1328
0x74 0x00 0x02 0x98
# CHECK: jalrs $ra, $6
0x03 0xe6 0x4f 0x3c
sstankovicUnsubmitted
Not Done
ReplyInline Actions

Disassembler currently doesn't support jalrs with only one register (where $ra is implicit). I think it should be implemented. Also, add a testcase for it.

sstankovic: Disassembler currently doesn't support jalrs with only one register (where $ra is implicit). I…
sstankovicUnsubmitted
Not Done
ReplyInline Actions

Sorry, I meant assembler. But this should probably be part of a separate patch. (You may optionally add a TODO comment for it). So, this patch LGTM.

sstankovic: Sorry, I meant assembler. But this should probably be part of a separate patch. (You may…

test/MC/Disassembler/Mips/micromips_le.txt

Show First 20 Lines • Show All 288 Lines • ▼ Show 20 Lines
# CHECK: tnei $9, 17767 # CHECK: tnei $9, 17767
0x89 0x41 0x67 0x45 0x89 0x41 0x67 0x45
# CHECK: ll $2, 8($4) # CHECK: ll $2, 8($4)
0x44 0x60 0x08 0x30 0x44 0x60 0x08 0x30
# CHECK: sc $2, 8($4) # CHECK: sc $2, 8($4)
0x44 0x60 0x08 0xb0 0x44 0x60 0x08 0xb0
# CHECK: lwxs $2, $3($4)
0x64 0x00 0x18 0x11
# CHECK: bgezals $6, 1332
0x66 0x42 0x9a 0x02
# CHECK: bltzals $6, 1332
0x26 0x42 0x9a 0x02
# CHECK: beqzc $9, 1332
0xe9 0x40 0x9a 0x02
# CHECK: bnezc $9, 1332
0xa9 0x40 0x9a 0x02
# CHECK: jals 1328
0x00 0x74 0x98 0x02
# CHECK: jalrs $ra, $6
0xe6 0x03 0x3c 0x4f