Page Menu
Home
Phabricator
This is an archive of the discontinued LLVM Phabricator instance.
Paths
Table of Contents
t
-
cfe/trunk/lib/Tooling/
-
trunk/
-
lib/
-
Tooling/
-
AllTUsExecution.cpp
Hide Panel
f
Keyboard Reference
?
Differential
D54104
[Tooling] Correct the total number of files being processed when `filter` is provided.
Closed
Public
Authored by
hokein
on Nov 5 2018, 6:52 AM.
Download Raw Diff
Details
Reviewers
ioeric
Commits
rG63ecf07311ca: [Tooling] Correct the total number of files being processed when `filter` is…
rC346135: [Tooling] Correct the total number of files being processed when `filter` is…
rL346135: [Tooling] Correct the total number of files being processed when `filter` is…
Diff Detail
Repository
rL LLVM
Event Timeline
hokein
created this revision.
Nov 5 2018, 6:52 AM
Harbormaster
completed remote builds in
B24548: Diff 172582
.
Nov 5 2018, 6:52 AM
ioeric
accepted this revision.
Nov 5 2018, 6:55 AM
ioeric
added inline comments.
lib/Tooling/AllTUsExecution.cpp
103 ↗
(On Diff #172582)
nit:
if (match) then push_back
would be a line shorter.
125 ↗
(On Diff #172582)
This is unused now
This revision is now accepted and ready to land.
Nov 5 2018, 6:55 AM
hokein
updated this revision to
Diff 172585
.
Nov 5 2018, 7:09 AM
hokein
marked 2 inline comments as done.
Comment Actions
Address comments.
Harbormaster
completed remote builds in
B24550: Diff 172585
.
Nov 5 2018, 7:09 AM
Closed by commit
rL346135: [Tooling] Correct the total number of files being processed when `filter` is…
(authored by
hokein
).
·
Explain Why
Nov 5 2018, 7:10 AM
This revision was automatically updated to reflect the committed changes.
Herald
added a subscriber:
llvm-commits
.
·
View Herald Transcript
Nov 5 2018, 7:10 AM