This is an archive of the discontinued LLVM Phabricator instance.

Differential D53981

Fix whitespace in test/Assembler/fast-math-flags.ll
ClosedPublic

Authored by cameron.mcinally on Nov 1 2018, 9:22 AM.

Details

Reviewers
arsenm
Commits
rG17b5b69e3289: Fix whitespace in test/Assembler/fast-math-flags.ll
rL345851: Fix whitespace in test/Assembler/fast-math-flags.ll
Summary

This was branched from D53877. Clean up some extra whitespace in a few tests.

Diff Detail

Repository
rL LLVM

Event Timeline

cameron.mcinally created this revision.Nov 1 2018, 9:22 AM
Herald added subscribers: llvm-commits, wdng. · View Herald TranscriptNov 1 2018, 9:22 AM
cameron.mcinally mentioned this in D53877: [IR] Strawman for dedicated FNeg IR instruction.Nov 1 2018, 9:24 AM
arsenm added inline comments.Nov 1 2018, 9:37 AM
fast-math-flags.ll
1–2

Add -strict-whitespace to FileCheck

cameron.mcinally updated this revision to Diff 172153.Nov 1 2018, 9:50 AM

Add -strict-whitespace option.

Do you want to remove the extra white space on the lhs of the assignments too? E.g.:

%arr = load [3 x float], [3 x float]* @arr

cameron.mcinally marked an inline comment as done.Nov 1 2018, 9:50 AM
arsenm accepted this revision.Nov 1 2018, 9:51 AM

LGTM. The important part is checking the output formatting

This revision is now accepted and ready to land.Nov 1 2018, 9:51 AM
Closed by commit rL345851: Fix whitespace in test/Assembler/fast-math-flags.ll (authored by mcinally). · Explain WhyNov 1 2018, 10:00 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
132 lines

Diff 172144

fast-math-flags.ll

; RUN: llvm-as < %s | llvm-dis | FileCheck %s ; RUN: llvm-as < %s | llvm-dis | FileCheck %s
; RUN: opt -S < %s | FileCheck %s ; RUN: opt -S < %s | FileCheck %s
arsenmUnsubmitted
Done
ReplyInline Actions

Add -strict-whitespace to FileCheck

arsenm: Add -strict-whitespace to FileCheck
; RUN: verify-uselistorder %s ; RUN: verify-uselistorder %s
@addr = external global i64 @addr = external global i64
@select = external global i1 @select = external global i1
@vec = external global <3 x float> @vec = external global <3 x float>
@arr = external global [3 x float] @arr = external global [3 x float]
declare float @foo(float) declare float @foo(float)
define float @none(float %x, float %y) { define float @none(float %x, float %y) {
entry: entry:
; CHECK: %vec = load <3 x float>, <3 x float>* @vec ; CHECK: %vec = load <3 x float>, <3 x float>* @vec
%vec = load <3 x float>, <3 x float>* @vec %vec = load <3 x float>, <3 x float>* @vec
; CHECK: %select = load i1, i1* @select ; CHECK: %select = load i1, i1* @select
%select = load i1, i1* @select %select = load i1, i1* @select
; CHECK: %arr = load [3 x float], [3 x float]* @arr ; CHECK: %arr = load [3 x float], [3 x float]* @arr
%arr = load [3 x float], [3 x float]* @arr %arr = load [3 x float], [3 x float]* @arr
; CHECK: %a = fadd float %x, %y ; CHECK: %a = fadd float %x, %y
%a = fadd float %x, %y %a = fadd float %x, %y
; CHECK: %a_vec = fadd <3 x float> %vec, %vec ; CHECK: %a_vec = fadd <3 x float> %vec, %vec
%a_vec = fadd <3 x float> %vec, %vec %a_vec = fadd <3 x float> %vec, %vec
; CHECK: %b = fsub float %x, %y ; CHECK: %b = fsub float %x, %y
%b = fsub float %x, %y %b = fsub float %x, %y
; CHECK: %b_vec = fsub <3 x float> %vec, %vec ; CHECK: %b_vec = fsub <3 x float> %vec, %vec
%b_vec = fsub <3 x float> %vec, %vec %b_vec = fsub <3 x float> %vec, %vec
; CHECK: %c = fmul float %x, %y ; CHECK: %c = fmul float %x, %y
%c = fmul float %x, %y %c = fmul float %x, %y
; CHECK: %c_vec = fmul <3 x float> %vec, %vec ; CHECK: %c_vec = fmul <3 x float> %vec, %vec
%c_vec = fmul <3 x float> %vec, %vec %c_vec = fmul <3 x float> %vec, %vec
; CHECK: %d = fdiv float %x, %y ; CHECK: %d = fdiv float %x, %y
%d = fdiv float %x, %y %d = fdiv float %x, %y
; CHECK: %d_vec = fdiv <3 x float> %vec, %vec ; CHECK: %d_vec = fdiv <3 x float> %vec, %vec
%d_vec = fdiv <3 x float> %vec, %vec %d_vec = fdiv <3 x float> %vec, %vec
; CHECK: %e = frem float %x, %y ; CHECK: %e = frem float %x, %y
%e = frem float %x, %y %e = frem float %x, %y
; CHECK: %e_vec = frem <3 x float> %vec, %vec ; CHECK: %e_vec = frem <3 x float> %vec, %vec
%e_vec = frem <3 x float> %vec, %vec %e_vec = frem <3 x float> %vec, %vec
; CHECK: ret float %e ; CHECK: ret float %e
ret float %e ret float %e
} }
; CHECK: no_nan ; CHECK: no_nan
define float @no_nan(float %x, float %y) { define float @no_nan(float %x, float %y) {
entry: entry:
; CHECK: %vec = load <3 x float>, <3 x float>* @vec ; CHECK: %vec = load <3 x float>, <3 x float>* @vec
%vec = load <3 x float>, <3 x float>* @vec %vec = load <3 x float>, <3 x float>* @vec
; CHECK: %select = load i1, i1* @select ; CHECK: %select = load i1, i1* @select
%select = load i1, i1* @select %select = load i1, i1* @select
; CHECK: %arr = load [3 x float], [3 x float]* @arr ; CHECK: %arr = load [3 x float], [3 x float]* @arr
%arr = load [3 x float], [3 x float]* @arr %arr = load [3 x float], [3 x float]* @arr
; CHECK: %a = fadd nnan float %x, %y ; CHECK: %a = fadd nnan float %x, %y
%a = fadd nnan float %x, %y %a = fadd nnan float %x, %y
; CHECK: %a_vec = fadd nnan <3 x float> %vec, %vec ; CHECK: %a_vec = fadd nnan <3 x float> %vec, %vec
%a_vec = fadd nnan <3 x float> %vec, %vec %a_vec = fadd nnan <3 x float> %vec, %vec
; CHECK: %b = fsub nnan float %x, %y ; CHECK: %b = fsub nnan float %x, %y
%b = fsub nnan float %x, %y %b = fsub nnan float %x, %y
; CHECK: %b_vec = fsub nnan <3 x float> %vec, %vec ; CHECK: %b_vec = fsub nnan <3 x float> %vec, %vec
%b_vec = fsub nnan <3 x float> %vec, %vec %b_vec = fsub nnan <3 x float> %vec, %vec
; CHECK: %c = fmul nnan float %x, %y ; CHECK: %c = fmul nnan float %x, %y
%c = fmul nnan float %x, %y %c = fmul nnan float %x, %y
; CHECK: %c_vec = fmul nnan <3 x float> %vec, %vec ; CHECK: %c_vec = fmul nnan <3 x float> %vec, %vec
%c_vec = fmul nnan <3 x float> %vec, %vec %c_vec = fmul nnan <3 x float> %vec, %vec
; CHECK: %d = fdiv nnan float %x, %y ; CHECK: %d = fdiv nnan float %x, %y
%d = fdiv nnan float %x, %y %d = fdiv nnan float %x, %y
; CHECK: %d_vec = fdiv nnan <3 x float> %vec, %vec ; CHECK: %d_vec = fdiv nnan <3 x float> %vec, %vec
%d_vec = fdiv nnan <3 x float> %vec, %vec %d_vec = fdiv nnan <3 x float> %vec, %vec
; CHECK: %e = frem nnan float %x, %y ; CHECK: %e = frem nnan float %x, %y
%e = frem nnan float %x, %y %e = frem nnan float %x, %y
; CHECK: %e_vec = frem nnan <3 x float> %vec, %vec ; CHECK: %e_vec = frem nnan <3 x float> %vec, %vec
%e_vec = frem nnan <3 x float> %vec, %vec %e_vec = frem nnan <3 x float> %vec, %vec
; CHECK: ret float %e ; CHECK: ret float %e
ret float %e ret float %e
} }
; CHECK: @contract( ; CHECK: @contract(
define float @contract(float %x, float %y) { define float @contract(float %x, float %y) {
entry: entry:
; CHECK: %a = fsub contract float %x, %y ; CHECK: %a = fsub contract float %x, %y
Show All 32 Lines
entry: entry:
; CHECK: %vec = load <3 x float>, <3 x float>* @vec ; CHECK: %vec = load <3 x float>, <3 x float>* @vec
%vec = load <3 x float>, <3 x float>* @vec %vec = load <3 x float>, <3 x float>* @vec
; CHECK: %select = load i1, i1* @select ; CHECK: %select = load i1, i1* @select
%select = load i1, i1* @select %select = load i1, i1* @select
; CHECK: %arr = load [3 x float], [3 x float]* @arr ; CHECK: %arr = load [3 x float], [3 x float]* @arr
%arr = load [3 x float], [3 x float]* @arr %arr = load [3 x float], [3 x float]* @arr
; CHECK: %a = fadd nnan ninf float %x, %y ; CHECK: %a = fadd nnan ninf float %x, %y
%a = fadd ninf nnan float %x, %y %a = fadd ninf nnan float %x, %y
; CHECK: %a_vec = fadd nnan <3 x float> %vec, %vec ; CHECK: %a_vec = fadd nnan <3 x float> %vec, %vec
%a_vec = fadd nnan <3 x float> %vec, %vec %a_vec = fadd nnan <3 x float> %vec, %vec
; CHECK: %b = fsub nnan float %x, %y ; CHECK: %b = fsub nnan float %x, %y
%b = fsub nnan float %x, %y %b = fsub nnan float %x, %y
; CHECK: %b_vec = fsub nnan ninf <3 x float> %vec, %vec ; CHECK: %b_vec = fsub nnan ninf <3 x float> %vec, %vec
%b_vec = fsub ninf nnan <3 x float> %vec, %vec %b_vec = fsub ninf nnan <3 x float> %vec, %vec
; CHECK: %c = fmul nnan float %x, %y ; CHECK: %c = fmul nnan float %x, %y
%c = fmul nnan float %x, %y %c = fmul nnan float %x, %y
; CHECK: %c_vec = fmul nnan <3 x float> %vec, %vec ; CHECK: %c_vec = fmul nnan <3 x float> %vec, %vec
%c_vec = fmul nnan <3 x float> %vec, %vec %c_vec = fmul nnan <3 x float> %vec, %vec
; CHECK: %d = fdiv nnan ninf float %x, %y ; CHECK: %d = fdiv nnan ninf float %x, %y
%d = fdiv ninf nnan float %x, %y %d = fdiv ninf nnan float %x, %y
; CHECK: %d_vec = fdiv nnan <3 x float> %vec, %vec ; CHECK: %d_vec = fdiv nnan <3 x float> %vec, %vec
%d_vec = fdiv nnan <3 x float> %vec, %vec %d_vec = fdiv nnan <3 x float> %vec, %vec
; CHECK: %e = frem nnan float %x, %y ; CHECK: %e = frem nnan float %x, %y
%e = frem nnan float %x, %y %e = frem nnan float %x, %y
; CHECK: %e_vec = frem nnan ninf <3 x float> %vec, %vec ; CHECK: %e_vec = frem nnan ninf <3 x float> %vec, %vec
%e_vec = frem ninf nnan <3 x float> %vec, %vec %e_vec = frem ninf nnan <3 x float> %vec, %vec
; CHECK: ret float %e ; CHECK: ret float %e
ret float %e ret float %e
} }
; CHECK: mixed_flags ; CHECK: mixed_flags
define float @mixed_flags(float %x, float %y) { define float @mixed_flags(float %x, float %y) {
entry: entry:
; CHECK: %vec = load <3 x float>, <3 x float>* @vec ; CHECK: %vec = load <3 x float>, <3 x float>* @vec
%vec = load <3 x float>, <3 x float>* @vec %vec = load <3 x float>, <3 x float>* @vec
; CHECK: %select = load i1, i1* @select ; CHECK: %select = load i1, i1* @select
Show All 16 Lines
; CHECK: %d = fdiv nnan ninf arcp float %x, %y ; CHECK: %d = fdiv nnan ninf arcp float %x, %y
%d = fdiv arcp ninf nnan float %x, %y %d = fdiv arcp ninf nnan float %x, %y
; CHECK: %d_vec = fdiv fast <3 x float> %vec, %vec ; CHECK: %d_vec = fdiv fast <3 x float> %vec, %vec
%d_vec = fdiv fast nnan arcp <3 x float> %vec, %vec %d_vec = fdiv fast nnan arcp <3 x float> %vec, %vec
; CHECK: %e = frem nnan nsz float %x, %y ; CHECK: %e = frem nnan nsz float %x, %y
%e = frem nnan nsz float %x, %y %e = frem nnan nsz float %x, %y
; CHECK: %e_vec = frem nnan <3 x float> %vec, %vec ; CHECK: %e_vec = frem nnan <3 x float> %vec, %vec
%e_vec = frem nnan <3 x float> %vec, %vec %e_vec = frem nnan <3 x float> %vec, %vec
; CHECK: ret float %e ; CHECK: ret float %e
ret float %e ret float %e
} }