Page MenuHomePhabricator

[Orc] make getResponsibilitySetWithLegacyFn behavior match with LegacyJITSymbolResolver::getResponsibilitySet
Needs ReviewPublic

Authored by twoh on Oct 30 2018, 4:45 PM.


Summary replaces lookupFlags with getResponsibilitySet, and this introduces a behaviral change in LegacyJITSymbolResolver::getResponsibilitySet (If there is no existing definition then the caller is responsible for materializing it. However, this changes is missed from getResponsibilitySetWithLegacyFn. Though I'm not very familiar with Orc code base, I think the behavior of these two functions supposed to match, and the patch actually fixes "symbols not found" error in our codebase using OrcJIT.

Diff Detail

Event Timeline

twoh created this revision.Oct 30 2018, 4:45 PM
twoh added a comment.Nov 5 2018, 8:59 AM

Friendly ping. Thanks!

lhames added a comment.Mar 3 2020, 2:44 PM

twoh: Sorry this sat unreviewed for so long. Is this still hitting you in your codebase, or have you moved over to ORCv2?

Since the current plan is to kill off the legacy ORC stuff in ORCv1 I'm inclined to leave things as-is until we delete this code.

Herald added a project: Restricted Project. · View Herald TranscriptMar 3 2020, 2:44 PM