This is an archive of the discontinued LLVM Phabricator instance.

Differential D53849

[analyzer] Enable retain count checking for OSObject by default
ClosedPublic

Authored by george.karpenkov on Oct 29 2018, 4:37 PM.

Details

Reviewers
dcoughlin
NoQ
Commits
rG57ef3a02e21a: [analyzer] Enable retain count checking for OSObject by defa
rC345745: [analyzer] Enable retain count checking for OSObject by defa
rL345745: [analyzer] Enable retain count checking for OSObject by defa
Summary

The FP rate seems to be good enough now.

Diff Detail

Repository
rL LLVM

Event Timeline

george.karpenkov created this revision.Oct 29 2018, 4:37 PM
Herald added subscribers: dkrupp, donat.nagy, Szelethus and 5 others. · View Herald TranscriptOct 29 2018, 4:37 PM
NoQ accepted this revision.Oct 29 2018, 4:55 PM

Yay!

This revision is now accepted and ready to land.Oct 29 2018, 4:55 PM
Closed by commit rL345745: [analyzer] Enable retain count checking for OSObject by defa (authored by george.karpenkov). · Explain WhyOct 31 2018, 10:40 AM
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: llvm-commits. · View Herald TranscriptOct 31 2018, 10:41 AM

Revision Contents

PathSize
cfe/
trunk/
lib/
StaticAnalyzer/
Checkers/
RetainCountChecker/
2 lines
test/
Analysis/
2 lines

Diff 171963

cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker/RetainCountChecker.h

Show First 20 Lines • Show All 276 Lines • ▼ Show 20 Linespublic:
RetainCountChecker(AnalyzerOptions &Options) RetainCountChecker(AnalyzerOptions &Options)
: Options(Options), ShouldResetSummaryLog(false), : Options(Options), ShouldResetSummaryLog(false),
IncludeAllocationLine( IncludeAllocationLine(
shouldIncludeAllocationSiteInLeakDiagnostics(Options)) {} shouldIncludeAllocationSiteInLeakDiagnostics(Options)) {}
~RetainCountChecker() override { DeleteContainerSeconds(DeadSymbolTags); } ~RetainCountChecker() override { DeleteContainerSeconds(DeadSymbolTags); }
bool shouldCheckOSObjectRetainCount() const { bool shouldCheckOSObjectRetainCount() const {
return Options.getBooleanOption("CheckOSObject", false, this); return Options.getBooleanOption("CheckOSObject", true, this);
} }
void checkEndAnalysis(ExplodedGraph &G, BugReporter &BR, void checkEndAnalysis(ExplodedGraph &G, BugReporter &BR,
ExprEngine &Eng) const { ExprEngine &Eng) const {
// FIXME: This is a hack to make sure the summary log gets cleared between // FIXME: This is a hack to make sure the summary log gets cleared between
// analyses of different code bodies. // analyses of different code bodies.
// //
// Why is this necessary? Because a checker's lifetime is tied to a // Why is this necessary? Because a checker's lifetime is tied to a
▲ Show 20 Lines • Show All 163 Lines • Show Last 20 Lines

cfe/trunk/test/Analysis/osobject-retain-release.cpp

// RUN: %clang_analyze_cc1 -analyze -analyzer-checker=core,osx.cocoa.RetainCount -analyzer-config osx.cocoa.RetainCount:CheckOSObject=true -analyzer-output=text -verify %s // RUN: %clang_analyze_cc1 -analyze -analyzer-checker=core,osx.cocoa.RetainCount -analyzer-output=text -verify %s
struct OSMetaClass; struct OSMetaClass;
#define TRUSTED __attribute__((annotate("rc_ownership_trusted_implementation"))) #define TRUSTED __attribute__((annotate("rc_ownership_trusted_implementation")))
#define OS_CONSUME TRUSTED __attribute__((annotate("rc_ownership_consumed"))) #define OS_CONSUME TRUSTED __attribute__((annotate("rc_ownership_consumed")))
#define OS_RETURNS_RETAINED TRUSTED __attribute__((annotate("rc_ownership_returns_retained"))) #define OS_RETURNS_RETAINED TRUSTED __attribute__((annotate("rc_ownership_returns_retained")))
#define OS_RETURNS_NOT_RETAINED TRUSTED __attribute__((annotate("rc_ownership_returns_not_retained"))) #define OS_RETURNS_NOT_RETAINED TRUSTED __attribute__((annotate("rc_ownership_returns_not_retained")))
▲ Show 20 Lines • Show All 195 Lines • Show Last 20 Lines