Page MenuHomePhabricator

[OCaml] Fix incorrect use of CAMLlocal in nested blocks
ClosedPublic

Authored by jberdine on Oct 29 2018, 3:31 PM.

Details

Summary

The OCaml manual states:

Local variables of type value must be declared with one of the
CAMLlocal macros. [...] These macros must be used at the beginning
of the function, not in a nested block.

This patch moves several instances of CAMLlocal macros from nested
blocks to the function beginning.

Diff Detail

Repository
rL LLVM

Event Timeline

jberdine created this revision.Oct 29 2018, 3:31 PM
whitequark accepted this revision.Oct 29 2018, 3:51 PM
This revision is now accepted and ready to land.Oct 29 2018, 3:51 PM

@whitequark, could I bother you to commit this for me?

CodaFi added a subscriber: CodaFi.Nov 5 2018, 5:36 PM

Apologies for not bringing this up in the earlier patch, but is there a reason this isn't using/building on the existing DI C bindings we have?

@CodaFi Did you mean to commentn on D52210? I'm confused here...

This revision was automatically updated to reflect the committed changes.