This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Workaround using new Clang with an old NDK.
ClosedPublic

Authored by danalbert on Oct 25 2018, 9:33 AM.

Details

Reviewers
eugenis
Summary

We're using an old NDK and a new Clang. New Clangs default to
-stdlib=libc++ for Android, but those libraries cannot be found by
default with an old NDK. Use an explicit -stdlib=libstdc++ in the
cxx_mode_flags.

Event Timeline

danalbert created this revision.Oct 25 2018, 9:33 AM
Herald added subscribers: Restricted Project, delcypher, dberris and 2 others. · View Herald TranscriptOct 25 2018, 9:33 AM

Could you change config.clangxx in test/asan/lit.cfg instead?

Or, rather, define something like common_cxxflags in test/lit.common.cfg and apply them in all sanitizer tests.
This script should not edit compilation flags.

danalbert updated this revision to Diff 172440.Nov 2 2018, 2:50 PM
danalbert edited the summary of this revision. (Show Details)

Thanks, hadn't found that file. Much cleaner.

eugenis accepted this revision.Nov 2 2018, 3:07 PM

Yes, this is much better!
LGTM

This revision is now accepted and ready to land.Nov 2 2018, 3:07 PM
danalbert closed this revision.Nov 2 2018, 4:01 PM

r346051