[X86] Add a common-avx512 CPU to match icc's -xCOMMON-AVX512 option

[craig.topper]

Summary

This adds a common-avx512 CPU to target the avx512 features common between skylake-avx512 and knl.

This is the clang version of D53663

[craig.topper]

Abandoning after an internal conversation.

include/clang/Basic/X86Target.def

 /// Haswell microarchitecture based processors.
 PROC_WITH_FEAT(Haswell, "haswell", PROC_64_BIT, FEATURE_AVX2)
 PROC_ALIAS(Haswell, "core-avx2")
 
 /// \name Broadwell
 /// Broadwell microarchitecture based processors.
 PROC_WITH_FEAT(Broadwell, "broadwell", PROC_64_BIT, FEATURE_AVX2)
 
+/// \name CommonAVX512
+/// Intersection of SKX and KNL.
+PROC(CommonAVX512, "common-avx512", PROC_64_BIT)
+
 /// \name Skylake Client
 /// Skylake client microarchitecture based processors.
 PROC_WITH_FEAT(SkylakeClient, "skylake", PROC_64_BIT, FEATURE_AVX2)
 
 /// \name Skylake Server
 /// Skylake server microarchitecture based processors.
 PROC_WITH_FEAT(SkylakeServer, "skylake-avx512", PROC_64_BIT, FEATURE_AVX512F)
 PROC_ALIAS(SkylakeServer, "skx")

lib/Basic/Targets/X86.cpp

case CK_Bonnell:
     setFeatureEnabledImpl(Features, "sahf", true);
     break;
 
   case CK_KNM:
     // TODO: Add avx5124fmaps/avx5124vnniw.
     setFeatureEnabledImpl(Features, "avx512vpopcntdq", true);
     LLVM_FALLTHROUGH;
   case CK_KNL:
-    setFeatureEnabledImpl(Features, "avx512f", true);
-    setFeatureEnabledImpl(Features, "avx512cd", true);
     setFeatureEnabledImpl(Features, "avx512er", true);
     setFeatureEnabledImpl(Features, "avx512pf", true);
-    setFeatureEnabledImpl(Features, "prfchw", true);
     setFeatureEnabledImpl(Features, "prefetchwt1", true);
+    LLVM_FALLTHROUGH;
+  case CK_CommonAVX512:
+    setFeatureEnabledImpl(Features, "avx512f", true);
+    setFeatureEnabledImpl(Features, "avx512cd", true);
+    setFeatureEnabledImpl(Features, "prfchw", true);
     setFeatureEnabledImpl(Features, "fxsr", true);
     setFeatureEnabledImpl(Features, "rdseed", true);
     setFeatureEnabledImpl(Features, "adx", true);
     setFeatureEnabledImpl(Features, "lzcnt", true);
     setFeatureEnabledImpl(Features, "bmi", true);
     setFeatureEnabledImpl(Features, "bmi2", true);
     setFeatureEnabledImpl(Features, "fma", true);
     setFeatureEnabledImpl(Features, "rdrnd", true);
void X86TargetInfo::getTargetDefines(const LangOptions &Opts,
   case CK_Cannonlake:
   case CK_IcelakeClient:
   case CK_IcelakeServer:
     // FIXME: Historically, we defined this legacy name, it would be nice to
     // remove it at some point. We've never exposed fine-grained names for
     // recent primary x86 CPUs, and we should keep it that way.
     defineCPUMacros(Builder, "corei7");
     break;
+  case CK_CommonAVX512:
+    break;
   case CK_KNL:
     defineCPUMacros(Builder, "knl");
     break;
   case CK_KNM:
     break;
   case CK_Lakemont:
     defineCPUMacros(Builder, "i586", /*Tuning*/false);
     defineCPUMacros(Builder, "pentium", /*Tuning*/false);

test/Frontend/x86-target-cpu.c

 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu skylake -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu skylake-avx512 -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu skx -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu cannonlake -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu icelake-client -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu icelake-server -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu knl -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu knm -verify %s
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu common-avx512 -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu bonnell -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu silvermont -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu k8 -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu opteron -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu athlon64 -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu athlon-fx -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu k8-sse3 -verify %s
 // RUN: %clang_cc1 -triple x86_64-unknown-unknown -target-cpu opteron-sse3 -verify %s

test/Misc/target-invalid-cpu-note.c

 
 // RUN: not %clang_cc1 -triple i386--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix X86
 // X86: error: unknown target CPU 'not-a-cpu'
 // X86: note: valid target CPU values are: i386, i486, winchip-c6, winchip2, c3,
 // X86-SAME: i586, pentium, pentium-mmx, pentiumpro, i686, pentium2, pentium3,
 // X86-SAME: pentium3m, pentium-m, c3-2, yonah, pentium4, pentium4m, prescott,
 // X86-SAME: nocona, core2, penryn, bonnell, atom, silvermont, slm, goldmont, goldmont-plus, tremont,
 // X86-SAME: nehalem, corei7, westmere, sandybridge, corei7-avx, ivybridge,
-// X86-SAME: core-avx-i, haswell, core-avx2, broadwell, skylake, skylake-avx512,
+// X86-SAME: core-avx-i, haswell, core-avx2, broadwell, common-avx512, skylake, skylake-avx512,
 // X86-SAME: skx, cannonlake, icelake-client, icelake-server, knl, knm, lakemont, k6, k6-2, k6-3,
 // X86-SAME: athlon, athlon-tbird, athlon-xp, athlon-mp, athlon-4, k8, athlon64,
 // X86-SAME: athlon-fx, opteron, k8-sse3, athlon64-sse3, opteron-sse3, amdfam10,
 // X86-SAME: barcelona, btver1, btver2, bdver1, bdver2, bdver3, bdver4, znver1,
 // X86-SAME: x86-64, geode
 
 // RUN: not %clang_cc1 -triple x86_64--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix X86_64
 // X86_64: error: unknown target CPU 'not-a-cpu'
 // X86_64: note: valid target CPU values are: nocona, core2, penryn, bonnell,
 // X86_64-SAME: atom, silvermont, slm, goldmont, goldmont-plus, tremont, nehalem, corei7, westmere,
 // X86_64-SAME: sandybridge, corei7-avx, ivybridge, core-avx-i, haswell,
-// X86_64-SAME: core-avx2, broadwell, skylake, skylake-avx512, skx, cannonlake,
+// X86_64-SAME: core-avx2, broadwell, common-avx512, skylake, skylake-avx512, skx, cannonlake,
 // X86_64-SAME: icelake-client, icelake-server, knl, knm, k8, athlon64, athlon-fx, opteron, k8-sse3,
 // X86_64-SAME: athlon64-sse3, opteron-sse3, amdfam10, barcelona, btver1,
 // X86_64-SAME: btver2, bdver1, bdver2, bdver3, bdver4, znver1, x86-64
 
 // RUN: not %clang_cc1 -triple nvptx--- -target-cpu not-a-cpu -fsyntax-only %s 2>&1 | FileCheck %s --check-prefix NVPTX
 // NVPTX: error: unknown target CPU 'not-a-cpu'
 // NVPTX: note: valid target CPU values are: sm_20, sm_21, sm_30, sm_32, sm_35,
 // NVPTX-SAME: sm_37, sm_50, sm_52, sm_53, sm_60, sm_61, sm_62, sm_70, sm_72

test/Preprocessor/predefined-arch-macros.c

 // CHECK_BROADWELL_M64: #define __amd64 1
 // CHECK_BROADWELL_M64: #define __amd64__ 1
 // CHECK_BROADWELL_M64: #define __corei7 1
 // CHECK_BROADWELL_M64: #define __corei7__ 1
 // CHECK_BROADWELL_M64: #define __tune_corei7__ 1
 // CHECK_BROADWELL_M64: #define __x86_64 1
 // CHECK_BROADWELL_M64: #define __x86_64__ 1
 
+// RUN: %clang -march=common-avx512 -m32 -E -dM %s -o - 2>&1 \
+// RUN:     -target i386-unknown-linux \
+// RUN:   | FileCheck -match-full-lines %s -check-prefix=CHECK_COMMONAVX512_M32
+// CHECK_COMMONAVX512_M32: #define __ADX__ 1
+// CHECK_COMMONAVX512_M32: #define __AVX2__ 1
+// CHECK_COMMONAVX512_M32: #define __AVX512CD__ 1
+// CHECK_COMMONAVX512_M32: #define __AVX512F__ 1
+// CHECK_COMMONAVX512_M32: #define __AVX__ 1
+// CHECK_COMMONAVX512_M32: #define __BMI2__ 1
+// CHECK_COMMONAVX512_M32: #define __BMI__ 1
+// CHECK_COMMONAVX512_M32: #define __F16C__ 1
+// CHECK_COMMONAVX512_M32: #define __FMA__ 1
+// CHECK_COMMONAVX512_M32: #define __LZCNT__ 1
+// CHECK_COMMONAVX512_M32: #define __MMX__ 1
+// CHECK_COMMONAVX512_M32: #define __MOVBE__ 1
+// CHECK_COMMONAVX512_M32: #define __PCLMUL__ 1
+// CHECK_COMMONAVX512_M32: #define __POPCNT__ 1
+// CHECK_COMMONAVX512_M32: #define __PRFCHW__ 1
+// CHECK_COMMONAVX512_M32: #define __RDRND__ 1
+// CHECK_COMMONAVX512_M32: #define __RDSEED__ 1
+// CHECK_COMMONAVX512_M32: #define __SSE2__ 1
+// CHECK_COMMONAVX512_M32: #define __SSE3__ 1
+// CHECK_COMMONAVX512_M32: #define __SSE4_1__ 1
+// CHECK_COMMONAVX512_M32: #define __SSE4_2__ 1
+// CHECK_COMMONAVX512_M32: #define __SSE__ 1
+// CHECK_COMMONAVX512_M32: #define __SSSE3__ 1
+// CHECK_COMMONAVX512_M32: #define __XSAVEOPT__ 1
+// CHECK_COMMONAVX512_M32: #define __XSAVE__ 1
+// CHECK_COMMONAVX512_M32: #define __i386 1
+// CHECK_COMMONAVX512_M32: #define __i386__ 1
+// CHECK_COMMONAVX512_M32: #define i386 1
+
+// RUN: %clang -march=common-avx512 -m64 -E -dM %s -o - 2>&1 \
+// RUN:     -target i386-unknown-linux \
+// RUN:   | FileCheck -match-full-lines %s -check-prefix=CHECK_COMMONAVX512_M64
+// CHECK_COMMONAVX512_M64: #define __ADX__ 1
+// CHECK_COMMONAVX512_M64: #define __AVX2__ 1
+// CHECK_COMMONAVX512_M64: #define __AVX512CD__ 1
+// CHECK_COMMONAVX512_M64: #define __AVX512F__ 1
+// CHECK_COMMONAVX512_M64: #define __AVX__ 1
+// CHECK_COMMONAVX512_M64: #define __BMI2__ 1
+// CHECK_COMMONAVX512_M64: #define __BMI__ 1
+// CHECK_COMMONAVX512_M64: #define __F16C__ 1
+// CHECK_COMMONAVX512_M64: #define __FMA__ 1
+// CHECK_COMMONAVX512_M64: #define __LZCNT__ 1
+// CHECK_COMMONAVX512_M64: #define __MMX__ 1
+// CHECK_COMMONAVX512_M64: #define __MOVBE__ 1
+// CHECK_COMMONAVX512_M64: #define __PCLMUL__ 1
+// CHECK_COMMONAVX512_M64: #define __POPCNT__ 1
+// CHECK_COMMONAVX512_M64: #define __PRFCHW__ 1
+// CHECK_COMMONAVX512_M64: #define __RDRND__ 1
+// CHECK_COMMONAVX512_M64: #define __RDSEED__ 1
+// CHECK_COMMONAVX512_M64: #define __SSE2_MATH__ 1
+// CHECK_COMMONAVX512_M64: #define __SSE2__ 1
+// CHECK_COMMONAVX512_M64: #define __SSE3__ 1
+// CHECK_COMMONAVX512_M64: #define __SSE4_1__ 1
+// CHECK_COMMONAVX512_M64: #define __SSE4_2__ 1
+// CHECK_COMMONAVX512_M64: #define __SSE_MATH__ 1
+// CHECK_COMMONAVX512_M64: #define __SSE__ 1
+// CHECK_COMMONAVX512_M64: #define __SSSE3__ 1
+// CHECK_COMMONAVX512_M64: #define __XSAVEOPT__ 1
+// CHECK_COMMONAVX512_M64: #define __XSAVE__ 1
+// CHECK_COMMONAVX512_M64: #define __amd64 1
+// CHECK_COMMONAVX512_M64: #define __amd64__ 1
+// CHECK_COMMONAVX512_M64: #define __x86_64 1
+// CHECK_COMMONAVX512_M64: #define __x86_64__ 1
+
 // RUN: %clang -march=skylake -m32 -E -dM %s -o - 2>&1 \
 // RUN:     -target i386-unknown-linux \
 // RUN:   | FileCheck -match-full-lines %s -check-prefix=CHECK_SKL_M32
 // CHECK_SKL_M32: #define __ADX__ 1
 // CHECK_SKL_M32: #define __AES__ 1
 // CHECK_SKL_M32: #define __AVX2__ 1
 // CHECK_SKL_M32: #define __AVX__ 1
 // CHECK_SKL_M32: #define __BMI2__ 1