Page MenuHomePhabricator

[analyzer] Fixed bitvector from model always being unsigned
ClosedPublic

Authored by mikhail.ramalho on Oct 24 2018, 3:38 AM.

Details

Summary

Getting an APSInt from the model always returned an unsigned integer because of the unused parameter.

This was not breaking any test case because no code relies on the actual value of the integer returned here, but rather it is only used to check if a symbol has more than one solution in getSymVal.

Diff Detail

Repository
rL LLVM

Event Timeline

Makes sense.

Do you have examples where it makes difference in practice?

This revision is now accepted and ready to land.Oct 24 2018, 10:21 AM

It doesn't make any difference in practice, for now.

It should only start to be a problem if people use the counterexample to do fancy stuff (maybe the automatic test generation that Artem mentioned in the mailing list?).

This revision was automatically updated to reflect the committed changes.