This is an archive of the discontinued LLVM Phabricator instance.

Differential D53606

[cfi] Make sanstats print address of the check
ClosedPublic

Authored by vitalybuka on Oct 23 2018, 1:20 PM.

Download Raw Diff

Details

Reviewers

pcc

Commits

rGdb87ced890a6: [cfi] Make sanstats print address of the check
rL347600: [cfi] Make sanstats print address of the check

Summary

Help with off-line symbolization or other type debugging.

Diff Detail

Repository

rL LLVM

Build Status

Buildable 24101
Build 24100: arc lint + arc unit

Event Timeline

vitalybuka created this revision.Oct 23 2018, 1:20 PM

Harbormaster completed remote builds in B24101: Diff 170739.Oct 23 2018, 1:20 PM

ping

Test case?

test

Harbormaster completed remote builds in B25119: Diff 174489.Nov 16 2018, 5:34 PM

In D53606#1301944, @vitalybuka wrote:

test

done

ping

LGTM

This revision is now accepted and ready to land.Nov 26 2018, 11:38 AM

Closed by commit rL347600: [cfi] Make sanstats print address of the check (authored by vitalybuka). · Explain WhyNov 26 2018, 1:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

tools/

sanstats/

sanstats.cpp

5 lines

Diff 170739

llvm/tools/sanstats/sanstats.cpp

Show First 20 Lines • Show All 75 Lines • ▼ Show 20 Lines	while (1) {
if (Begin == End)		if (Begin == End)
return nullptr;		return nullptr;

// As the instrumentation tracks the return address and not		// As the instrumentation tracks the return address and not
// the address of the call to `__sanitizer_stat_report` we		// the address of the call to `__sanitizer_stat_report` we
// remove one from the address to get the correct DI.		// remove one from the address to get the correct DI.
if (Expected<DILineInfo> LineInfo =		if (Expected<DILineInfo> LineInfo =
Symbolizer.symbolizeCode(Filename, Addr - 1)) {		Symbolizer.symbolizeCode(Filename, Addr - 1)) {
llvm::outs() << LineInfo->FileName << ':' << LineInfo->Line << ' '		llvm::outs() << format_hex(Addr - 1, 18) << ' ' << LineInfo->FileName
<< LineInfo->FunctionName << ' ';		<< ':' << LineInfo->Line << ' ' << LineInfo->FunctionName
		<< ' ';
} else {		} else {
logAllUnhandledErrors(LineInfo.takeError(), llvm::outs(), "<error> ");		logAllUnhandledErrors(LineInfo.takeError(), llvm::outs(), "<error> ");
}		}

switch (KindFromData(Data, SizeofPtr)) {		switch (KindFromData(Data, SizeofPtr)) {
case SanStat_CFI_VCall:		case SanStat_CFI_VCall:
llvm::outs() << "cfi-vcall";		llvm::outs() << "cfi-vcall";
break;		break;
▲ Show 20 Lines • Show All 48 Lines • Show Last 20 Lines