Page MenuHomePhabricator

[bash-autocompletion] Fix bug when a flag ends with '='
ClosedPublic

Authored by yamaguchi on Oct 23 2018, 10:17 AM.

Details

Reviewers
teemperor
ruiu
Summary

There was a bug that when a flag ends with '=' and no value was suggested,
clang autocompletes the flag itself.
For example, in bash, it looked like this:

$ clang -fmodule-file=[tab]
-> $clang -fmodule-file=-fmodule-file

This is not what we expect. We expect a file autocompletion when no value
was found. With this patch, pressing tab suggests files in the current
directory.

Event Timeline

yamaguchi created this revision.Oct 23 2018, 10:17 AM
ruiu accepted this revision.Oct 23 2018, 1:56 PM

LGTM

This revision is now accepted and ready to land.Oct 23 2018, 1:56 PM