Page MenuHomePhabricator

TableGen: fix assert in !cast when used out of definition in a multiclass
ClosedPublic

Authored by vpykhtin on Oct 10 2018, 2:43 AM.

Details

Summary

The attached testcase asserts on !cast without the patch. The reason is that there is no CurRec when !cast used inside foreach. Let's postpone CurRec check until isFinal.

Diff Detail

Repository
rL LLVM

Event Timeline

vpykhtin created this revision.Oct 10 2018, 2:43 AM
nhaehnle accepted this revision.Oct 10 2018, 2:46 AM

Nice catch. LGTM.

This revision is now accepted and ready to land.Oct 10 2018, 2:46 AM
This revision was automatically updated to reflect the committed changes.