[llvm-pdbutil] Pretty print PDBSymbolUsingNamespace symbols

[zturner]

tools/llvm-pdbutil/PrettyCompilandDumper.cpp

226 ↗

(On Diff #168015)

We try to make it look like actual C++ code. So with that in mind we should put a space between the two words and colorize them as C++ keywords. Can you write this as:

WithColor(Printer, PDB_ColorItem::Keyword).get() << "using namespace ";

[zturner]

tools/llvm-pdbutil/PrettyCompilandDumper.cpp

228–229 ↗

(On Diff #168015)

Also I think we can drop the if statement here and write this all on line line.

WithColor(Printer, PDB_ColorItem::Identifier).get() << Symbol.getName();

If the string is empty it will just be a no-op, which is fine.

llvm/trunk/test/tools/llvm-pdbdump/Inputs/UsingNamespaceTest.cpp

+// Compile with "cl /c /Zi /GR- UsingNamespaceTest.cpp"
+// Link with "link UsingNamespaceTest.obj /debug /nodefaultlib /entry:main"
+
+namespace NS {
+  int foo() { return 1; }
+}
+
+using namespace NS;
+int main(int argc, char **argv) {
+  return foo();
+}

llvm/trunk/test/tools/llvm-pdbdump/usingnamespace.test

+; RUN: llvm-pdbutil pretty -module-syms %p/Inputs/UsingNamespaceTest.pdb > %t
+; RUN: FileCheck -input-file=%t %s
+
+; CHECK: ---SYMBOLS---
+; CHECK-NEXT: {{.*}}UsingNamespaceTest.obj
+; CHECK-DAG: using namespace NS

llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.h

public:
   void dump(const PDBSymbolCompilandDetails &Symbol) override;
   void dump(const PDBSymbolCompilandEnv &Symbol) override;
   void dump(const PDBSymbolData &Symbol) override;
   void dump(const PDBSymbolFunc &Symbol) override;
   void dump(const PDBSymbolLabel &Symbol) override;
   void dump(const PDBSymbolThunk &Symbol) override;
   void dump(const PDBSymbolTypeTypedef &Symbol) override;
   void dump(const PDBSymbolUnknown &Symbol) override;
+  void dump(const PDBSymbolUsingNamespace &Symbol) override;
 
 private:
   LinePrinter &Printer;
 };
 }
 }
 
 #endif

llvm/trunk/tools/llvm-pdbutil/PrettyCompilandDumper.cpp

 #include "llvm/DebugInfo/PDB/PDBSymbolData.h"
 #include "llvm/DebugInfo/PDB/PDBSymbolFunc.h"
 #include "llvm/DebugInfo/PDB/PDBSymbolFuncDebugEnd.h"
 #include "llvm/DebugInfo/PDB/PDBSymbolFuncDebugStart.h"
 #include "llvm/DebugInfo/PDB/PDBSymbolLabel.h"
 #include "llvm/DebugInfo/PDB/PDBSymbolThunk.h"
 #include "llvm/DebugInfo/PDB/PDBSymbolTypeFunctionSig.h"
 #include "llvm/DebugInfo/PDB/PDBSymbolUnknown.h"
+#include "llvm/DebugInfo/PDB/PDBSymbolUsingNamespace.h"
 #include "llvm/Support/Format.h"
 #include "llvm/Support/Path.h"
 #include "llvm/Support/raw_ostream.h"
 
 #include <utility>
 
 using namespace llvm;
 using namespace llvm::pdb;

 }
 
 void CompilandDumper::dump(const PDBSymbolTypeTypedef &Symbol) {}
 
 void CompilandDumper::dump(const PDBSymbolUnknown &Symbol) {
   Printer.NewLine();
   Printer << "unknown (" << Symbol.getSymTag() << ")";
 }
+
+void CompilandDumper::dump(const PDBSymbolUsingNamespace &Symbol) {
+  if (Printer.IsSymbolExcluded(Symbol.getName()))
+    return;
+
+  Printer.NewLine();
+  Printer << "using namespace ";
+  std::string Name = Symbol.getName();
+  WithColor(Printer, PDB_ColorItem::Identifier).get() << Name;
+}