This is an archive of the discontinued LLVM Phabricator instance.

[mips] Use early exit in MipsAsmParser::matchCPURegisterName(). NFC.
ClosedPublic

Authored by vkalintiris on Sep 9 2014, 7:59 AM.

Diff Detail

Event Timeline

vkalintiris updated this revision to Diff 13468.Sep 9 2014, 7:59 AM
vkalintiris retitled this revision from to [mips] Refactor code to gain an extra identation level. No functional change..
vkalintiris updated this object.
vkalintiris edited the test plan for this revision. (Show Details)
vkalintiris added a reviewer: dsanders.
dsanders accepted this revision.Sep 11 2014, 6:29 AM
dsanders edited edge metadata.

The patch LGTM but could you change the message to something like '[mips] Use early exit in MipsAsmParser::matchCPURegisterName(). NFC'?

This revision is now accepted and ready to land.Sep 11 2014, 6:29 AM
vkalintiris edited edge metadata.
  • [mips] Refactor code to gain an extra identation level. No functional change.
ehostunreach retitled this revision from [mips] Refactor code to gain an extra identation level. No functional change. to [mips] Use early exit in MipsAsmParser::matchCPURegisterName(). NFC..Sep 11 2014, 7:30 AM
tomatabacu closed this revision.Sep 15 2014, 8:42 AM
tomatabacu updated this revision to Diff 13711.
tomatabacu added a subscriber: tomatabacu.

Closed by commit rL217774 (authored by @tomatabacu).