[libomptarget-nvptx] Enable asserts in bclib

[Hahnfeld]

Summary

If the user requested LIBOMPTARGET_NVPTX_DEBUG, include asserts in
the bitcode library. Everything else will have very unpleasent
effects because asserts will appear when falling back to the static
library libomptarget-nvptx.a.

[grokos]

Looks good. I have no idea why this option was left there...

[Hahnfeld]

In D52701#1250645, @grokos wrote:

Looks good. I have no idea why this option was left there...

For the record: I think that's a leftover from D45530.

libomptarget/deviceRTLs/nvptx/CMakeLists.txt

set(LIBOMPTARGET_NVPTX_ENABLE_BCLIB ${bclib_default} CACHE BOOL
     "Enable CUDA LLVM bitcode offloading device RTL.")
   if (${LIBOMPTARGET_NVPTX_ENABLE_BCLIB})
     if (NOT ${LIBOMPTARGET_NVPTX_BCLIB_SUPPORTED})
       libomptarget_error_say("Cannot build CUDA LLVM bitcode offloading device RTL!")
     endif()
     libomptarget_say("Building CUDA LLVM bitcode offloading device RTL.")
 
     # Set flags for LLVM Bitcode compilation.
-    set(bc_flags ${LIBOMPTARGET_NVPTX_SELECTED_CUDA_COMPILER_FLAGS} -DOMPTARGET_NVPTX_TEST=0)
+    set(bc_flags ${LIBOMPTARGET_NVPTX_SELECTED_CUDA_COMPILER_FLAGS})
     if(${LIBOMPTARGET_NVPTX_DEBUG})
       set(bc_flags ${bc_flags} -DOMPTARGET_NVPTX_DEBUG=-1)
     else()
       set(bc_flags ${bc_flags} -DOMPTARGET_NVPTX_DEBUG=0)
     endif()
 
     # CUDA 9 header files use the nv_weak attribute which clang is not yet prepared
     # to handle. Therefore, we use 'weak' instead. We are compiling only for the