This is an archive of the discontinued LLVM Phabricator instance.

[MCA] Remove SM.hasNext() call in FetchStage::execute.
ClosedPublic

Authored by orodley on Sep 27 2018, 10:31 PM.

Reviewers

Commits

Summary

This is redundant, as FetchStage::getNextInstruction already checks this
and returns llvm::ErrorSuccess() as appropriate.

NFC.

Repository

rL LLVM

Build Status

Buildable 23232
Build 23231: arc lint + arc unit

LGTM.

Thanks!

This revision is now accepted and ready to land.Sep 28 2018, 1:18 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

tools/

llvm-mca/

lib/

Stages/

2 lines

Show First 20 Lines • Show All 54 Lines • ▼ Show 20 Lines	llvm::Error FetchStage::execute(InstRef & /unused /) {

SM.updateNext();		SM.updateNext();

// Move the program counter.		// Move the program counter.
return getNextInstruction();		return getNextInstruction();
}		}

llvm::Error FetchStage::cycleStart() {		llvm::Error FetchStage::cycleStart() {
if (!CurrentInstruction && SM.hasNext())		if (!CurrentInstruction)
return getNextInstruction();		return getNextInstruction();
return llvm::ErrorSuccess();		return llvm::ErrorSuccess();
}		}

llvm::Error FetchStage::cycleEnd() {		llvm::Error FetchStage::cycleEnd() {
// Find the first instruction which hasn't been retired.		// Find the first instruction which hasn't been retired.
const InstMap::iterator It =		const InstMap::iterator It =
llvm::find_if(Instructions, [](const InstMap::value_type &KeyValuePair) {		llvm::find_if(Instructions, [](const InstMap::value_type &KeyValuePair) {
Show All 11 Lines