Page MenuHomePhabricator

Fix an assert in the implementation of -Wquoted-include-in-framework-header
ClosedPublic

Authored by erik.pilkington on Sep 18 2018, 5:43 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

clang/lib/Lex/HeaderSearch.cpp
670 ↗(On Diff #166054)

Crash was here, if ToFramework is empty because no "Foo.framework" entry found in the path.

bruno added a comment.Sep 18 2018, 6:31 PM

Hi Erik,

Thanks for catching this.

Can you rename the test and the input file path to something more meaningful? Better yet if you remove the radar bits. I think you can actually squeeze this test in test/Modules/double-quotes.m.

Sure, the new patch moves the test to double-quotes.m and gives it a more meaningful name.

Thanks!

bruno accepted this revision.Sep 20 2018, 11:43 AM

LGTM with one more small change.

clang/test/Modules/double-quotes.m
35 ↗(On Diff #166070)

Please write a meaningful message here instead, the radar number in the commit message should be enough to track this down later if needed.

This revision is now accepted and ready to land.Sep 20 2018, 11:43 AM
This revision was automatically updated to reflect the committed changes.