This is an archive of the discontinued LLVM Phabricator instance.

Differential D52206

[LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices
ClosedPublic

Authored by jberdine on Sep 17 2018, 6:23 PM.

Details

Reviewers
whitequark
Commits
rG6c1f7a51b9e1: [LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices
rL342434: [LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices
Summary

ConstantExpr supports getIndices, but prior to this patch
LLVMGetNumIndices and LLVMGetIndices would error on them.

Diff Detail

Event Timeline

jberdine created this revision.Sep 17 2018, 6:23 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 17 2018, 6:23 PM
Harbormaster completed remote builds in B22754: Diff 165864.Sep 17 2018, 6:26 PM
whitequark accepted this revision.Sep 17 2018, 6:34 PM
This revision is now accepted and ready to land.Sep 17 2018, 6:34 PM
Closed by commit rL342434: [LLVM-C] Add support for ConstantExpr in LLVMGetNumIndices and LLVMGetIndices (authored by whitequark). · Explain WhySep 17 2018, 6:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
IR/
4 lines

Diff 165864

lib/IR/Core.cpp

Show First 20 Lines • Show All 2,626 Lines • ▼ Show 20 Lines
unsigned LLVMGetNumIndices(LLVMValueRef Inst) { unsigned LLVMGetNumIndices(LLVMValueRef Inst) {
auto *I = unwrap(Inst); auto *I = unwrap(Inst);
if (auto *GEP = dyn_cast<GetElementPtrInst>(I)) if (auto *GEP = dyn_cast<GetElementPtrInst>(I))
return GEP->getNumIndices(); return GEP->getNumIndices();
if (auto *EV = dyn_cast<ExtractValueInst>(I)) if (auto *EV = dyn_cast<ExtractValueInst>(I))
return EV->getNumIndices(); return EV->getNumIndices();
if (auto *IV = dyn_cast<InsertValueInst>(I)) if (auto *IV = dyn_cast<InsertValueInst>(I))
return IV->getNumIndices(); return IV->getNumIndices();
if (auto *CE = dyn_cast<ConstantExpr>(I))
return CE->getIndices().size();
llvm_unreachable( llvm_unreachable(
"LLVMGetNumIndices applies only to extractvalue and insertvalue!"); "LLVMGetNumIndices applies only to extractvalue and insertvalue!");
} }
const unsigned *LLVMGetIndices(LLVMValueRef Inst) { const unsigned *LLVMGetIndices(LLVMValueRef Inst) {
auto *I = unwrap(Inst); auto *I = unwrap(Inst);
if (auto *EV = dyn_cast<ExtractValueInst>(I)) if (auto *EV = dyn_cast<ExtractValueInst>(I))
return EV->getIndices().data(); return EV->getIndices().data();
if (auto *IV = dyn_cast<InsertValueInst>(I)) if (auto *IV = dyn_cast<InsertValueInst>(I))
return IV->getIndices().data(); return IV->getIndices().data();
if (auto *CE = dyn_cast<ConstantExpr>(I))
return CE->getIndices().data();
llvm_unreachable( llvm_unreachable(
"LLVMGetIndices applies only to extractvalue and insertvalue!"); "LLVMGetIndices applies only to extractvalue and insertvalue!");
} }
/*===-- Instruction builders ----------------------------------------------===*/ /*===-- Instruction builders ----------------------------------------------===*/
LLVMBuilderRef LLVMCreateBuilderInContext(LLVMContextRef C) { LLVMBuilderRef LLVMCreateBuilderInContext(LLVMContextRef C) {
▲ Show 20 Lines • Show All 951 Lines • Show Last 20 Lines