Page MenuHomePhabricator

Also manages clang-X as tool for scan-build
ClosedPublic

Authored by sylvestre.ledru on Sep 16 2018, 11:46 AM.

Diff Detail

Repository
rC Clang

Event Timeline

Nitpick: This regex is far too broad to cover the rare use case where you'd be invoking clang as clang-N. I think something like clang(?:\-[789])? would be more suitable?

This revision was not accepted when it landed; it landed in state Needs Review.Sep 16 2018, 12:38 PM
Closed by commit rC342350: Also manages clang-X as tool for scan-build (authored by sylvestre, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.

@kristina sorry, I missed your comment. I just followed what we are doing with gcc. Do you want me to update it?

Just a minor suggestion, I think it would make it more clear as before LLVM 7, Clang did not have a version number with the main executable. GCC is slightly less consistent with their formats as they usually ship as host compilers with various suffixes, but with Clang it can only be clang, clang-7 or 8 (or 9 in the future) although it's still generally invoked as clang unless you have multiple installations.

$triple-clang, also