This is an archive of the discontinued LLVM Phabricator instance.

[X86] Remove an fp->int->fp domain crossing in LowerUINT_TO_FP_i64.
ClosedPublic

Authored by craig.topper on Sep 14 2018, 11:20 PM.

Details

Summary

This unfortunately adds a move, but isn't that better than going to the int domain and back?

Diff Detail

Event Timeline

craig.topper created this revision.Sep 14 2018, 11:20 PM
RKSimon accepted this revision.Sep 15 2018, 6:22 AM

LGTM - since we're targetting older targets with pre-AVX code the domain penalty is more likely to be present.

lib/Target/X86/X86ISelLowering.cpp
16740

Update this to 'shuffle + addsd' ?

This revision is now accepted and ready to land.Sep 15 2018, 6:22 AM
This revision was automatically updated to reflect the committed changes.