This is an archive of the discontinued LLVM Phabricator instance.

Differential D51981

lld-link: If an input file doesn't exist, don't print diagnostics after "input file doesn't exist".
ClosedPublic

Authored by thakis on Sep 12 2018, 6:51 AM.

Details

Reviewers
ruiu
Commits
rGf1828e324090: lld-link: For nonexisting inputs, omit follow-on diagnostics
rL342158: lld-link: For nonexisting inputs, omit follow-on diagnostics
rLLD342158: lld-link: For nonexisting inputs, omit follow-on diagnostics
Summary

For lld-link missing.obj, lld-link currently prints:

lld-link: error: could not open foo.obj: No such file or directory
lld-link: warning: /machine is not specified. x64 is assumed
lld-link: error: subsystem must be defined

The 2nd and 3rd diagnostics are consequences of the input not existing and are not interesting. If input files are missing, the best thing we can do is point that out and then return.

Diff Detail

Event Timeline

thakis created this revision.Sep 12 2018, 6:51 AM
thakis edited the summary of this revision. (Show Details)
thakis added a reviewer: ruiu.
thakis added a subscriber: llvm-commits.
thakis added a comment.Sep 12 2018, 7:00 AM

(Forcing an email to be sent since I accidentally clicked "save" before adding llvm-commits)

ruiu accepted this revision.Sep 13 2018, 6:48 AM

LGTM

This revision is now accepted and ready to land.Sep 13 2018, 6:48 AM
Closed by commit rLLD342158: lld-link: For nonexisting inputs, omit follow-on diagnostics (authored by nico). · Explain WhySep 13 2018, 11:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lld/
COFF/
3 lines
test/
COFF/
5 lines

Diff 165074

lld/COFF/Driver.cpp

Show First 20 Lines • Show All 1,230 Lines • ▼ Show 20 Linesvoid LinkerDriver::link(ArrayRef<const char *> ArgsArr) {
// Windows specific -- Create a resource file containing a manifest file. // Windows specific -- Create a resource file containing a manifest file.
if (Config->Manifest == Configuration::Embed) if (Config->Manifest == Configuration::Embed)
addBuffer(createManifestRes(), false); addBuffer(createManifestRes(), false);
// Read all input files given via the command line. // Read all input files given via the command line.
run(); run();
if (errorCount())
return;
// We should have inferred a machine type by now from the input files, but if // We should have inferred a machine type by now from the input files, but if
// not we assume x64. // not we assume x64.
if (Config->Machine == IMAGE_FILE_MACHINE_UNKNOWN) { if (Config->Machine == IMAGE_FILE_MACHINE_UNKNOWN) {
warn("/machine is not specified. x64 is assumed"); warn("/machine is not specified. x64 is assumed");
Config->Machine = AMD64; Config->Machine = AMD64;
} }
// Input files can be Windows resource files (.res files). We use // Input files can be Windows resource files (.res files). We use
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines

lld/test/COFF/could-not-open.test

  • This file was added.
RUN: not lld-link 01 2>&1 | FileCheck %s
CHECK: could not open 01
CHECK-NOT: /machine is not specified
CHECK-NOT: subsystem must be defined