Page MenuHomePhabricator

[AArch64 BE] Emission of BUILD_VECTORs can be incorrect in BE mode - bic, orr
ClosedPublic

Authored by rmaprath on Sep 4 2014, 7:20 AM.

Details

Reviewers
t.p.northover
Summary

Hi Tim,

Expanded the fix from [1] to cover bic, orr cases. Also fixed some internal test failures (adding necessary casts).

Please commit this patch if you think it looks OK. I've asked for commit rights in the meantime.

Thanks!

  • Asiri

[1] http://reviews.llvm.org/D5170

Diff Detail

Event Timeline

rmaprath updated this revision to Diff 13261.Sep 4 2014, 7:20 AM
rmaprath retitled this revision from to [AArch64 BE] Emission of BUILD_VECTORs can be incorrect in BE mode - bic, orr.
rmaprath updated this object.
rmaprath edited the test plan for this revision. (Show Details)
rmaprath added a reviewer: t.p.northover.
rmaprath added a subscriber: Unknown Object (MLST).
mroth added a subscriber: mroth.Sep 4 2014, 7:33 AM
t.p.northover accepted this revision.Sep 4 2014, 8:15 AM
t.p.northover edited edge metadata.

Yep. Looks fine to me so I've committed it in r217159.

Cheers.

Tim.

This revision is now accepted and ready to land.Sep 4 2014, 8:15 AM
rmaprath closed this revision.Sep 4 2014, 8:31 AM