Page MenuHomePhabricator

[CallSiteSplitting] Add debug location to created PHI nodes.
ClosedPublic

Authored by fhahn on Sep 11 2018, 2:53 AM.

Details

Summary

There are 2 cases when we create PHI nodes:

  • For the result of the call that was duplicated in the split blocks. Those PHI nodes should have the debug location of the call.
  • For values produced before the call. Those instructions need to be duplicated in the split blocks and the PHI nodes should have the debug locations of those instructions.

Fixes PR37962.

Diff Detail

Repository
rL LLVM

Event Timeline

fhahn created this revision.Sep 11 2018, 2:53 AM
junbuml accepted this revision.Sep 11 2018, 9:03 AM

LGTM

test/Transforms/CallSiteSplitting/callsite-split-preserve-debug.ll
26 ↗(On Diff #164829)

It would be good to add CHECK-LABEL for the TailBB before this.

This revision is now accepted and ready to land.Sep 11 2018, 9:03 AM
fhahn updated this revision to Diff 164908.Sep 11 2018, 9:18 AM

Strengthen test checks

fhahn marked an inline comment as done.Sep 11 2018, 9:18 AM
fhahn added inline comments.
test/Transforms/CallSiteSplitting/callsite-split-preserve-debug.ll
26 ↗(On Diff #164829)

Excellent suggestion, done!

This revision was automatically updated to reflect the committed changes.
fhahn marked an inline comment as done.