This is an archive of the discontinued LLVM Phabricator instance.

[Sanitizers] [MinGW] Check for __i386__ in addition to _M_IX86 for i386 specific details
ClosedPublic

Authored by mstorsjo on Sep 10 2018, 12:33 PM.

Details

Summary

The MinGW headers do define _M_IX86 (contrary to clang-cl and MSVC where it is a compiler predefined macro), but the headers that define it aren't included here.

Also check these defines for setting the symbol prefix, instead of inconsistently using _WIN64 for that.

Diff Detail

Repository
rL LLVM

Event Timeline

mstorsjo created this revision.Sep 10 2018, 12:33 PM
Herald added subscribers: Restricted Project, kubamracek. · View Herald TranscriptSep 10 2018, 12:33 PM
rnk accepted this revision.Sep 10 2018, 4:35 PM
This revision is now accepted and ready to land.Sep 10 2018, 4:35 PM
This revision was automatically updated to reflect the committed changes.