Page MenuHomePhabricator

[LNT] more pep8 code style fixes
ClosedPublic

Authored by danilaml on Sep 10 2018, 9:08 AM.

Details

Summary

PEP8 code style issues found by pycodestyle, ignoring "line to long: errors (IMHO it should be fine to set it to something less restrictive project-wide, like 100 or even 120).

Diff Detail

Repository
rL LLVM

Event Timeline

danilaml created this revision.Sep 10 2018, 9:08 AM
MatzeB accepted this revision.Sep 10 2018, 9:33 AM

LGTM.

Out of interest: What version of pycodestyle do you use? I currently seem to have version 2.4.0 here while I do see most of the issues, for example I don't see a message about the regex functions not using raw strings.

This revision is now accepted and ready to land.Sep 10 2018, 9:33 AM

I'm also using pycodestyle 2.4.0. The error/warning was not about raw strings in regexps, rather illegal escape sequences, i.e.:

.\lnt\server\db\regression.py:58:20: W605 invalid escape sequence '\d'

I think using raw strings is better than using something like \\d.

Btw, I doubt that I can commit to llvm repo, so I need somebody to commit this for me. Thanks!

Closed by commit rL342454: [LNT] more pep8 code style fixes (authored by kbeyls, committed by ). · Explain WhySep 18 2018, 2:22 AM
This revision was automatically updated to reflect the committed changes.

I'm also using pycodestyle 2.4.0. The error/warning was not about raw strings in regexps, rather illegal escape sequences, i.e.:

.\lnt\server\db\regression.py:58:20: W605 invalid escape sequence '\d'

I think using raw strings is better than using something like \\d.

Btw, I doubt that I can commit to llvm repo, so I need somebody to commit this for me. Thanks!

I've just committed this for you.
If you want, you should be able to get commit access, see https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access .

Thanks!

Kristof