Page MenuHomePhabricator

Move a transformation routine from LoopUtils to LoopVectorize.
ClosedPublic

Authored by tvvikram on Sep 9 2018, 12:18 AM.

Details

Summary

Move InductionDescriptor::transform() routine from LoopUtils to its only uses in LoopVectorize.cpp.
Specifically, the function is renamed as InnerLoopVectorizer::emitTransformedIndex().

This is a child to D51153.

Diff Detail

Repository
rL LLVM

Event Timeline

dmgreen accepted this revision.Sep 9 2018, 1:22 PM

Sounds good to me. WIth some optional nits.

Transforms/Vectorize/LoopVectorize.cpp
2808 ↗(On Diff #164584)

Nit: does this need a clang-format?

2850 ↗(On Diff #164584)

Nit: I tend to avoid auto in lines that don't already make the type obvious. This is just me though, so feel free to ignore.

This revision is now accepted and ready to land.Sep 9 2018, 1:22 PM
tvvikram updated this revision to Diff 164613.Sep 9 2018, 11:02 PM

Fix file paths. The previous patch missed root directory in its path.

tvvikram marked an inline comment as done.Sep 9 2018, 11:06 PM
tvvikram added inline comments.
Transforms/Vectorize/LoopVectorize.cpp
2850 ↗(On Diff #164584)

I am preferring "auto" :)

This revision was automatically updated to reflect the committed changes.