This is an archive of the discontinued LLVM Phabricator instance.

Differential D51583

Test commit - Remove a new line.
ClosedPublic

Authored by CarlosAlbertoEnciso on Sep 3 2018, 2:17 AM.

Download Raw Diff

Details

Reviewers

kristina

Commits

rGeaf2c1f449ca: Test commit.
rL341302: Test commit.

Summary

Test commit to check issues with new user-name.

Diff Detail

Event Timeline

CarlosAlbertoEnciso created this revision.Sep 3 2018, 2:17 AM

Maybe remove a comma in the comment? A lot of tools don't like trailing newlines.

Up to you, any NFC change is usually fine for this, though you didn't assign anyone as a reviewer.

This revision is now accepted and ready to land.Sep 3 2018, 2:29 AM

In D51583#1221878, @kristina wrote:

Maybe remove a comma in the comment? A lot of tools don't like trailing newlines.

Up to you, any NFC change is usually fine for this, though you didn't assign anyone as a reviewer.

@kristina, Thanks very much for the suggestion and for your review.

Closed by commit rL341302: Test commit. (authored by carlos.alberto.enciso). · Explain WhySep 3 2018, 2:42 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: llvm-commits. · View Herald TranscriptSep 3 2018, 2:42 AM

Revision Contents

Path

Size

test/

CodeGen/

X86/

debuginfo-locations-dce.ll

2 lines

Diff 163673

test/CodeGen/X86/debuginfo-locations-dce.ll

	Show First 20 Lines • Show All 63 Lines • ▼ Show 20 Lines
	; DW_AT_location (0x00000000			; DW_AT_location (0x00000000
	; [0x0000000000000009, 0x0000000000000012): DW_OP_reg17 XMM0)			; [0x0000000000000009, 0x0000000000000012): DW_OP_reg17 XMM0)
	; DW_AT_name ("MyVar")			; DW_AT_name ("MyVar")

	; CHECK-LABEL: DW_TAG_variable			; CHECK-LABEL: DW_TAG_variable
	; CHECK-NEXT: DW_AT_location{{.*}}			; CHECK-NEXT: DW_AT_location{{.*}}
	; CHECK-NEXT: {{.*}}DW_OP_reg17 XMM0			; CHECK-NEXT: {{.*}}DW_OP_reg17 XMM0
	; CHECK-NEXT: DW_AT_name{{.*}}("MyVar")			; CHECK-NEXT: DW_AT_name{{.*}}("MyVar")