This is an archive of the discontinued LLVM Phabricator instance.

Differential D51380

Fix incorrect usage of std::error_category
ClosedPublic

Authored by aganea on Aug 28 2018, 2:00 PM.

Details

Reviewers
ilya-biryukov
zturner
Commits
rG51c9349ab35f: [Preamble] Fix incorrect usage of std::error_category
rL340929: [Preamble] Fix incorrect usage of std::error_category
rC340929: [Preamble] Fix incorrect usage of std::error_category
Summary

As mentionned here, this change prevents a dangling pointer in std:error_code by using a singleton.

Diff Detail

Repository
rC Clang

Event Timeline

aganea created this revision.Aug 28 2018, 2:00 PM
Herald added a subscriber: cfe-commits. · View Herald TranscriptAug 28 2018, 2:00 PM
ilya-biryukov accepted this revision.Aug 29 2018, 4:58 AM

LGTM

This revision is now accepted and ready to land.Aug 29 2018, 4:58 AM
aganea added a comment.Aug 29 2018, 5:26 AM

Thank you!

ilya-biryukov added a comment.Aug 29 2018, 6:23 AM

Thanks for fixing this.

Closed by commit rC340929: [Preamble] Fix incorrect usage of std::error_category (authored by aganea). · Explain WhyAug 29 2018, 7:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
lib/
Frontend/
4 lines

Diff 163087

lib/Frontend/PrecompiledPreamble.cpp

Show First 20 Lines • Show All 736 Lines • ▼ Show 20 Lines
void PreambleCallbacks::BeforeExecute(CompilerInstance &CI) {} void PreambleCallbacks::BeforeExecute(CompilerInstance &CI) {}
void PreambleCallbacks::AfterExecute(CompilerInstance &CI) {} void PreambleCallbacks::AfterExecute(CompilerInstance &CI) {}
void PreambleCallbacks::AfterPCHEmitted(ASTWriter &Writer) {} void PreambleCallbacks::AfterPCHEmitted(ASTWriter &Writer) {}
void PreambleCallbacks::HandleTopLevelDecl(DeclGroupRef DG) {} void PreambleCallbacks::HandleTopLevelDecl(DeclGroupRef DG) {}
std::unique_ptr<PPCallbacks> PreambleCallbacks::createPPCallbacks() { std::unique_ptr<PPCallbacks> PreambleCallbacks::createPPCallbacks() {
return nullptr; return nullptr;
} }
static llvm::ManagedStatic<BuildPreambleErrorCategory> BuildPreambleErrCategory;
std::error_code clang::make_error_code(BuildPreambleError Error) { std::error_code clang::make_error_code(BuildPreambleError Error) {
return std::error_code(static_cast<int>(Error), BuildPreambleErrorCategory()); return std::error_code(static_cast<int>(Error), *BuildPreambleErrCategory);
} }
const char *BuildPreambleErrorCategory::name() const noexcept { const char *BuildPreambleErrorCategory::name() const noexcept {
return "build-preamble.error"; return "build-preamble.error";
} }
std::string BuildPreambleErrorCategory::message(int condition) const { std::string BuildPreambleErrorCategory::message(int condition) const {
switch (static_cast<BuildPreambleError>(condition)) { switch (static_cast<BuildPreambleError>(condition)) {
Show All 11 Lines