This is an archive of the discontinued LLVM Phabricator instance.

Differential D51285

Fix a build issue on Debian Jessie
AbandonedPublic

Authored by sylvestre.ledru on Aug 27 2018, 12:31 AM.

Details

Reviewers
None
Summary

Was failing with openmp/libomptarget/src/omptarget.cpp:37:21: error: 'va_start' was not declared in this scope

Diff Detail

Event Timeline

sylvestre.ledru created this revision.Aug 27 2018, 12:31 AM
Herald added a subscriber: guansong. · View Herald TranscriptAug 27 2018, 12:31 AM
Harbormaster completed remote builds in B21949: Diff 162625.Aug 27 2018, 12:32 AM
Hahnfeld added a subscriber: AlexEichenberger.Aug 27 2018, 12:35 AM

Yeah, sorry for break. Alex is currently favoring to rewrite the varargs functions into macros: D51226

sylvestre.ledru retitled this revision from Fix a build issue on Debian Jessie. Was failing with openmp/libomptarget/src/omptarget.cpp:37:21: error: 'va_start' was not declared in this scope to Fix a build issue on Debian Jessie.Aug 27 2018, 12:39 AM
sylvestre.ledru edited the summary of this revision. (Show Details)
Hahnfeld added a comment.Aug 27 2018, 11:29 AM

Should be fixed in rL340767

AlexEichenberger added a comment.Aug 27 2018, 7:59 PM

Yes, we should have done this right away. I did a rewrite of the functionality that uses header files already included; it was posted in D50522 and the changes were approved and pushed to svn.

Hahnfeld removed a reviewer: Hahnfeld.Sep 4 2018, 6:00 AM
Hahnfeld added a subscriber: Hahnfeld.
sylvestre.ledru abandoned this revision.Sep 6 2018, 1:24 AM

Revision Contents

PathSize
libomptarget/
src/
1 line

Diff 162625

libomptarget/src/omptarget.cpp

Show All 13 Lines
#include <omptarget.h> #include <omptarget.h>
#include "device.h" #include "device.h"
#include "private.h" #include "private.h"
#include "rtl.h" #include "rtl.h"
#include <cassert> #include <cassert>
#include <cstdarg>
#include <vector> #include <vector>
#include <mutex> #include <mutex>
#ifdef OMPTARGET_DEBUG #ifdef OMPTARGET_DEBUG
int DebugLevel = 0; int DebugLevel = 0;
#endif // OMPTARGET_DEBUG #endif // OMPTARGET_DEBUG
//////////////////////////////////////////////////////////////////////////////// ////////////////////////////////////////////////////////////////////////////////
▲ Show 20 Lines • Show All 713 Lines • Show Last 20 Lines